GLSP-1637: Upgrade to node 22 (#43)

- Upgrad codebase and workflows to node 22
- Streamline CLAUDE.md and AGENTS.md
- Add skills for verify,check and test

Author: tortmayr

.claude/skills/fix/SKILL.md

@@ -0,0 +1,12 @@
+---
+name: fix
+description: Auto-fix all lint, formatting, and copyright header issues across the workspace. Use when validation (`/verify`) fails or when explicitly requested.
+---
+
+Run the full auto-fix suite for this project from the repository root:
+
+```bash
+yarn fix:all
+```
+
+After fixing, report what changed. If any issues remain that couldn't be auto-fixed, list them and suggest manual fixes.

.claude/skills/test/SKILL.md

@@ -0,0 +1,68 @@
+---
+name: test
+description: Run Playwright tests for a specific integration (standalone, theia, or vscode). Handles full environment setup including repo preparation and .env generation. Usage - /test standalone, /test theia, or /test vscode.
+---
+
+Run Playwright tests for the specified integration. Handles environment setup, compilation, and test execution.
+
+## Usage
+
+`$ARGUMENTS` should be one of: `standalone`, `theia`, `vscode`, or empty (defaults to standalone).
+If `$ARGUMENTS` contains a specific test name pattern, run tests filtered by that pattern.
+
+Optionally, the user may specify a version (branch or tag) for the GLSP repositories, e.g. `/test standalone v2.6.0` or `/test theia release_2.7.0`.
+Extract the version from `$ARGUMENTS` if present (anything that is not an integration name or test pattern). If no version is specified, default to `master`.
+
+## Steps
+
+### 1. Environment Setup
+
+Check if `examples/workflow-test/.env` exists. If not, run the setup script to prepare repositories and generate it:
+
+```bash
+bash .claude/skills/test/scripts/setup-env.sh --protocol https
+```
+
+If the user specified a version (branch or tag), add `--branch <version>`:
+
+```bash
+bash .claude/skills/test/scripts/setup-env.sh --protocol https --branch <version>
+```
+
+When no version is specified, omit `--branch` entirely so each repository uses its own default branch.
+
+This script will:
+
+-   Clone and build required GLSP repositories (via `yarn repo prepare`) at the specified branch/tag if the `repositories/` directory is missing or incomplete
+-   Generate `examples/workflow-test/.env` with the correct values (server config, standalone URL, VSCode paths, etc.)
+
+If the `.env` file already exists, skip this step.
+
+### 2. Build
+
+Ensure the project is compiled:
+
+```bash
+yarn build
+```
+
+### 3. Run Tests
+
+Run the appropriate test command:
+
+-   **standalone** (default): `yarn test:standalone`
+-   **theia**: `yarn test:theia`
+-   **vscode**: `yarn test:vscode`
+-   **pattern match**: If `$ARGUMENTS` contains a specific test name pattern, run: `cd examples/workflow-test && yarn playwright test -g "$ARGUMENTS"`
+
+For **theia** tests, the Theia server needs to be running. Start it before running tests:
+
+```bash
+yarn repo theia-integration start &
+```
+
+Wait a few seconds for it to start before running the tests.
+
+### 4. Report Failures
+
+If tests fail, read the Playwright HTML report or error output and summarize failures with actionable suggestions.

.claude/skills/test/scripts/setup-env.sh

@@ -0,0 +1,76 @@
+#!/usr/bin/env bash
+# Setup script for GLSP Playwright test environment.
+# Ensures repositories are cloned/built and generates a .env file
+# in examples/workflow-test/ with the correct values.
+#
+# Usage: bash .claude/skills/test/scripts/setup-env.sh [--protocol ssh|https]
+
+set -euo pipefail
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+ROOT_DIR="$(cd "$SCRIPT_DIR/../../../.." && pwd)"
+WORKFLOW_TEST_DIR="$ROOT_DIR/examples/workflow-test"
+REPO_DIR="$WORKFLOW_TEST_DIR/repositories"
+ENV_FILE="$WORKFLOW_TEST_DIR/.env"
+
+# Parse arguments
+PROTOCOL_VALUE="https"
+BRANCH_VALUE=""
+
+while [[ $# -gt 0 ]]; do
+    case "$1" in
+        --protocol)
+            PROTOCOL_VALUE="${2:-https}"
+            shift 2
+            ;;
+        --branch)
+            BRANCH_VALUE="${2:-}"
+            shift 2
+            ;;
+        *)
+            shift
+            ;;
+    esac
+done
+
+# --- Step 1: Prepare repositories if needed ---
+# Check if the glsp-client repo exists and has been built
+if [ ! -d "$REPO_DIR/glsp-client/examples/workflow-standalone/app" ]; then
+    echo "Repositories not found or not built. Running 'yarn repo prepare'..."
+    cd "$ROOT_DIR"
+    BRANCH_ARG=""
+    if [ -n "$BRANCH_VALUE" ]; then
+        BRANCH_ARG="--branch $BRANCH_VALUE"
+    fi
+    yarn repo prepare --protocol "$PROTOCOL_VALUE" $BRANCH_ARG
+else
+    echo "Repositories already prepared."
+fi
+
+# --- Step 2: Generate .env file ---
+echo "Generating .env file at $ENV_FILE..."
+
+cd "$ROOT_DIR"
+STANDALONE_URL="$(yarn -s repo client url)"
+VSCODE_VSIX_PATH="$(yarn -s repo vscode-integration vsixPath)"
+
+cat > "$ENV_FILE" <<EOF
+GLSP_SERVER_DEBUG="true"
+GLSP_SERVER_PORT="8081"
+GLSP_SERVER_PLAYWRIGHT_MANAGED="true"
+GLSP_WEBSOCKET_PATH="workflow"
+GLSP_SERVER_TYPE="node"
+
+# Integration URLs
+STANDALONE_URL="$STANDALONE_URL"
+THEIA_URL="http://localhost:3000"
+
+# VSCode
+VSCODE_VSIX_ID="eclipse-glsp.workflow-vscode-example"
+VSCODE_VSIX_PATH="$VSCODE_VSIX_PATH"
+
+# Server start command (used by Playwright to manage the server)
+GLSP_SERVER_START_COMMAND="yarn repo node-server start"
+EOF
+
+echo "Environment setup complete. .env written to $ENV_FILE"

.claude/skills/verify/SKILL.md

@@ -0,0 +1,16 @@
+---
+name: verify
+description: Run full project validation (build,lint, format, copyright headers) to catch issues before committing. IMPORTANT - Proactively invoke this skill after completing any code changes (new features, bug fixes, refactors) before reporting completion to the user.
+---
+
+Run the full validation suite for this project from the repository root:
+
+```bash
+yarn check:all
+```
+
+On failure:
+
+1. Report which check failed and the specific errors
+2. Auto-fix by invoking the `/fix` skill
+3. Re-run `yarn check:all` to confirm everything passes

.github/workflows/ci.yml

@@ -18,7 +18,7 @@ jobs:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
       - uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
         with:
-          node-version: 20.x
+          node-version: 22.x
       - name: Install dependencies
         run: yarn install
       - name: Check for uncommitted changes in yarn.lock
@@ -35,7 +35,7 @@ jobs:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
       - uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
         with:
-          node-version: 20.x
+          node-version: 22.x
       - name: Install
         run: |
           yarn install --ignore-scripts
@@ -65,7 +65,7 @@ jobs:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
       - uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
         with:
-          node-version: '20'
+          node-version: '22'
       - name: Install dependencies
         run: yarn install
       - name: Prepare repos
@@ -103,7 +103,7 @@ jobs:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
       - uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
         with:
-          node-version: '20'
+          node-version: '22'
       - name: Set up JDK
         uses: actions/setup-java@99b8673ff64fbf99d8d325f52d9a5bdedb8483e9 # v4.2.1
         with:

.github/workflows/e2e.yml

@@ -30,7 +30,7 @@ jobs:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
       - uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
         with:
-          node-version: '20'
+          node-version: '22'
       - name: Install dependencies
         run: yarn install
       - name: Prepare repos

.github/workflows/publish.yml

@@ -67,7 +67,7 @@ jobs:
       - uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
         if: steps.check_changes.outputs.should_publish == 'true'
         with:
-          node-version: 20.x
+          node-version: 22.x
           registry-url: 'https://registry.npmjs.org'
 
       - name: Build

.gitignore

@@ -17,6 +17,9 @@ examples/workflow-test/playwright/.storage/*.json
 !*.env.example
 *.env
 
+
+.cache/
+
 ./claude/settings.local.json
 .claude/plans
 .reviews

AGENTS.md

@@ -1,51 +1,16 @@
-# Repository Guidelines
+# AGENTS.md
 
-## Project Structure & Module Organization
+## Project Overview
 
-This repository is a Yarn workspaces monorepo.
+Eclipse GLSP Playwright — a Playwright-based testing framework for GLSP (Graphical Language Server Platform) diagram editors. Supports Standalone, Theia, and VS Code integrations.
 
--   `packages/glsp-playwright/`: core library source (`src/`) and build output (`lib/`).
--   `examples/workflow-test/`: runnable Playwright example with page objects in `src/` and tests in `tests/`.
--   `docs/`: concept docs (`integration`, `extension`, `metadata`, and Playwright differences).
--   Root config files (`tsconfig.json`, `eslint.config.mjs`, `lerna.json`) define shared tooling.
+## Build & Development
 
-Use `packages/*` for reusable framework code and `examples/*` for integration demos and test fixtures.
+-   **Package manager**: Yarn 1.x (classic) — do not use Yarn 2+/Berry or npm
+-   **Build**: `yarn` from root installs and compiles everything
 
-## Build, Test, and Development Commands
+## Code Style Rules
 
-Run from repository root unless noted.
-
--   `yarn install`: install all workspace dependencies.
--   `yarn build`: compile TypeScript project references and rewrite path aliases.
--   `yarn lint`: run ESLint across the monorepo.
--   `yarn format` / `yarn format:check`: apply/check Prettier formatting.
--   `yarn test`: run example Playwright suite (`examples/workflow-test`).
--   `yarn test:standalone`, `yarn test:theia`, `yarn test:vscode`: run integration-specific test projects.
--   `yarn watch`: watch and rebuild TypeScript + alias output during development.
-
-## Coding Style & Naming Conventions
-
--   Language: TypeScript (`.ts`), 4-space indentation (follow existing files).
--   Formatting: Prettier via `@eclipse-glsp/prettier-config`.
--   Linting: ESLint (`eslint.config.mjs`) with strict TypeScript rules (for example, no floating promises).
--   Naming patterns:
-    -   Tests: `*.spec.ts` under `examples/workflow-test/tests/**`.
-    -   Page objects/helpers: `*.po.ts`, `*.capability.ts`, `*.integration.ts`.
-    -   Keep feature folders aligned with GLSP feature names (`tool-palette`, `validation`, `undo-redo`, etc.).
-
-## Testing Guidelines
-
-Tests use Playwright (`@playwright/test`) and run from compiled output (`examples/workflow-test/lib/tests`).
-
--   Build before testing when sources changed: `yarn build`.
--   Prefer targeted runs during development, then run `yarn test` before opening a PR.
--   Keep tests deterministic and cover standalone, Theia, and VS Code paths when relevant.
-
-## Commit & Pull Request Guidelines
-
-Commit history favors short, imperative subjects, often with issue IDs (example: `GLSP-1563: Update to node 20 and Theia 1.64.x`).
-
--   Reference related issue IDs in commit/PR text when available.
--   PRs should fill all template sections in `.github/PULL_REQUEST_TEMPLATE.md`:
-    `What it does`, `How to test`, `Follow-ups`, and `Changelog` impact.
--   Do not disclose vulnerabilities in issues/PRs; follow `SECURITY.md`.
+-   **No direct sprotty imports** — never import from `sprotty` or `sprotty-protocol` directly; use `@eclipse-glsp/client` instead (enforced by ESLint)
+-   **Floating promises** — `@typescript-eslint/no-floating-promises` is an error; always `await` or handle promises
+-   **Path alias** — `~/` maps to `packages/glsp-playwright/src/` in TypeScript configs

CLAUDE.md

@@ -1 +1,21 @@
-@AGENTS.md
+# CLAUDE.md
+
+## Project Overview
+
+Eclipse GLSP Playwright — a Playwright-based testing framework for GLSP (Graphical Language Server Platform) diagram editors. Supports Standalone, Theia, and VS Code integrations.
+
+## Build & Development
+
+-   **Package manager**: Yarn 1.x (classic) — do not use Yarn 2+/Berry or npm
+-   **Build**: `yarn` from root installs and compiles everything
+
+## Validation
+
+-   After completing any code changes, always run the `/verify` skill before reporting completion
+-   If verification fails, run the `/fix` skill to auto-fix issues, then re-run `/verify`
+
+## Code Style Rules
+
+-   **No direct sprotty imports** — never import from `sprotty` or `sprotty-protocol` directly; use `@eclipse-glsp/client` instead (enforced by ESLint)
+-   **Floating promises** — `@typescript-eslint/no-floating-promises` is an error; always `await` or handle promises
+-   **Path alias** — `~/` maps to `packages/glsp-playwright/src/` in TypeScript configs