Skip to content

Stabilize standalone e2e tests for glsp-client restyle #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tortmayr merged 1 commit into from
Jun 9, 2026
Merged

Stabilize standalone e2e tests for glsp-client restyle #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion examples/workflow-test/playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,10 @@ const config: PlaywrightTestConfig<GLSPPlaywrightOptions> = {
reporter: process.env.CI ? [['html', { open: 'never' }], ['@estruyf/github-actions-reporter']] : [['html', { open: 'never' }]],
use: {
actionTimeout: 0,
trace: 'on-first-retry'
trace: 'on-first-retry',
// Emulate `prefers-reduced-motion` so decorative entrance animations and transitions are
// disabled during tests.
contextOptions: { reducedMotion: 'reduce' }
},
webServer: buildWebServers(activeProjects),
projects: buildProjects(activeProjects)
Expand Down
4 changes: 3 additions & 1 deletion packages/glsp-playwright/src/glsp/graph/graph.po.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,9 @@ export class GLSPGraph extends PModelElement {
await creator();
}).toPass();

const ignore = ['.ghost-element', ...ids.map(id => `[id="${id}"]`)];
// Exclude transient creation feedback in addition to the already-present elements.
// This ensures stability against timing issues under load
const ignore = ['.ghost-element', '.feedback-edge', ...ids.map(id => `[id="${id}"]`)];
const createdLocator = this.locate().locator(`[data-svg-metadata-type="${elementType}"]:not(${ignore.join(',')})`);

await expect(createdLocator.first()).toBeVisible();
Expand Down
Loading