Conversation
Replace no-op elk factory with proper setup for isWebworker context. A small workaround/hack is required to present a `document` during construction of the factory which routes elkjs to the c orrect in-process message worker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Replace no-op elk factory with proper setup for isWebworker context. A small workaround/hack is required to present a
documentduring construction of the factory which routes elkjs to the c orrect in-process message workerFixes eclipse-glsp/glsp#1692
How to test
Then trigger a layout via Ctrl+Shift+L
I have already verified this locally. It might be easier to simple merge this after a positive code reivew and directly test in the glsp-client repo without the --external-server workaround.
Follow-ups
Changelog
Replaces the no-op webworker in the browser context with an actual working implementation.
Adopters that relied on the fact that the elkLayoutModule was effectivly no-op in the browser might need to adopt accordingly