Document Model Context Protocol (MCP) support#108
Conversation
- Replace the RequestExportSvgAction code block that wrongly showed the ExportSvgAction body and kind - Correct ChangeContainerOperation to extend Operation with a Point location - Type RejectAction.detail as string and RequestModelAction.options as Args - Renumber the duplicate 2.11.4 navigation action headings - Fix the SeverityLevel typo, the ActionMessage action field, and broken details/summary tags - Add fields that landed since the doc was written: RequestAction.timeout, Operation.args, EditorContext viewport/canvasBounds, ComputedBoundsAction layout/canvas/viewport, GLSPClient.onCurrentStateChanged, ghostElement - Note shutdownServer returns a promise-or-void and the protocol version is 1.0.0 - Define the referenced LayoutData, ElementAndLayoutData and ExportSvgOptions types Relates to #1673
|
🌐 Website preview: Removed (PR closed). |
- Add an MCP documentation section covering enablement, architecture, tool-platform integration, and security, link to the server-mcp docs - Include a high-level MCP architecture diagram (SVG) - Document the experimental mcpServer opt-in on InitializeParameters and the announced server URL on InitializeResult - Add the generic export pipeline with PNG support and deprecate the SVG-only export actions - Add the OriginViewportAction and MoveViewportAction viewport actions - Add GetEditorContextAction/EditorContextResult Fixes eclipse-glsp/glsp#1673
martin-fleck-at
force-pushed
the
issue-1673-mcp-protocol-docs
branch
from
b90724a to
ada436d
Compare
tortmayr
left a comment
tortmayr
left a comment
There was a problem hiding this comment.
Thanks for the thorough update.
Overall the doc changes look good to me.
I just have some minor comments inline
|
|
||
| In practice this lets an assistant answer questions about a diagram, suggest improvements, create or adjust elements from a natural-language request, or check the model for problems, all while the diagram stays open in the GLSP editor. | ||
|
|
||
| <small>*Experimental: MCP support is under active development and its configuration may still change. It is currently available for the [Node GLSP server](https://github.com/eclipse-glsp/glsp-server-node) only, with [Java server support](https://github.com/eclipse-glsp/glsp/issues/1672) planned.*</small> |
There was a problem hiding this comment.
Is the java server support really planned.
Right now its out of scope for u as default GLSP Team.
We are only doing it if we have a customer or other sponsor backing it, right?
There was a problem hiding this comment.
You are right, we should not over-promise here.
|
|
||
| ### Enabling MCP | ||
|
|
||
| MCP is opt-in and off by default. |
There was a problem hiding this comment.
This only covers the frontend side and makes it look like mcp servers are shipped by default and all an adopter as to do is to adapt the initialze message.
It misses that necessary integration of the dedicated mcp-server package in their backend.
I think this should be mentioned here.
There was a problem hiding this comment.
In general the how to integrate for the server side missing, ind is arguably the more important part 😉
There was a problem hiding this comment.
Very true, in my mind I was only focussed on the client-side but obviously the server actually requires more focus, haha! Will fix it!
|
|
||
| </details> | ||
|
|
||
| #### 2.8.4. Editor Context |
There was a problem hiding this comment.
This is currently grouped under client side actions which is missleading because its first and foremost a server side action.
Client can just query the editor context directly
There was a problem hiding this comment.
Good point! I'll fix it!
- Replace the Java-server note with a Node-only statement, without a speculative roadmap - Restructure Enabling MCP into a server step and a client step, each with a short code sample - Describe what the server and session modules configure and that they bind into different scopes - Document the mcpServer setup as a client-server handshake over initialize on the protocol page - Move GetEditorContext out of the client-side actions into its own server-initiated section - Correct the security note so only the default-on Host-header check is claimed, with Origin checking noted as off by default Relates to eclipse-glsp/glsp#1673
|
@tortmayr I pushed an update that hopefully addresses your concerns! |
tortmayr
left a comment
tortmayr
left a comment
There was a problem hiding this comment.
Thanks! Changes look good to me 👍🏼
2 participants
tool-platform integration, and security, linking to the server-mcp docs
the announced server URL on InitializeResult
with PNG support) and deprecate the SVG-only export actions
requests
Also: Sync protocol documentation with current GLSP client protocol
ExportSvgAction body and kind
details/summary tags
Operation.args, EditorContext viewport/canvasBounds, ComputedBoundsAction
layout/canvas/viewport, GLSPClient.onCurrentStateChanged, ghostElement
is 1.0.0
ExportSvgOptions types
Fixes #1673