Fix macOS RPATH handling and install rules for Iceoryx platform modules#2475
Open
artcore-c wants to merge 1 commit intoeclipse-iceoryx:release_2.0from
Open
Fix macOS RPATH handling and install rules for Iceoryx platform modules#2475artcore-c wants to merge 1 commit intoeclipse-iceoryx:release_2.0from
artcore-c wants to merge 1 commit intoeclipse-iceoryx:release_2.0from
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release_2.0 #2475 +/- ##
===============================================
- Coverage 78.88% 78.87% -0.01%
===============================================
Files 369 369
Lines 15200 15200
Branches 2105 2105
===============================================
- Hits 11990 11989 -1
- Misses 2492 2495 +3
+ Partials 718 716 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Member
|
@artcore-c I'm currently quite busy but try to have a closer look to this PR. It seems the CI also needs a fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
This PR improves compatibility with MacOS by correctly setting RPATH and install properties in key CMakeLists.txt files for iceoryx_binding_c and iceoryx_hoofs, particularly addressing dynamic linking of the iceoryx_platform module.
Changes include:
Added explicit INSTALL_RPATH and BUILD_RPATH for MacOS
Fixed missing install rule for iceoryx_platform
Ensured proper MACOSX_RPATH behavior
Tested with ros2_rolling and colcon build using --symlink-install on MacOS 12.7.6 x86_64 with SIP enabled.
Pre-Review Checklist for the PR Author
doc/website/release-notes/iceoryx-unreleased.mdiox-123-this-is-a-branch)iox-#123 commit text)task-list-completed)Checklist for the PR Reviewer
iceoryx_hoofshave been added to./clang-tidy-diff-scans.txtPost-review Checklist for the PR Author
References
Relates to MacOS build compatibility for ROS2 Rolling and downstream packages using colcon with symlink-install.
Targets compatibility with MacOS 12.7.6 (x86_64)
Apple SIP remains enabled during testing
All patched files build cleanly with
colcon build --symlink-installNo runtime logic or public API modified — strictly build system compatibility
Closes TBD