Fixed for Bug4986

Author: RagiGeorge

org.eclipse.jdt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/problem/ProblemReporter.java

@@ -3357,8 +3357,20 @@ public void importProblem(ImportReference importRef, Binding expectedImport) {
 			case ProblemReasons.NotVisible :
 			case ProblemReasons.NotAccessible :
 				id = (expectedImport.problemId() == ProblemReasons.NotVisible) ? IProblem.NotVisibleField : IProblem.NotAccessibleField;
-				readableArguments = new String[] {CharOperation.toString(importRef.tokens), new String(field.declaringClass.readableName())};
-				shortArguments = new String[] {CharOperation.toString(importRef.tokens), new String(field.declaringClass.shortReadableName())};
+				char[] readableName = CharOperation.concat(
+					field.declaringClass.readableName(),
+					field.name,
+					'.');
+				char[] shortReadableName = CharOperation.concat(
+					field.declaringClass.shortReadableName(),
+					field.name,
+					'.');
+				readableArguments = new String[] {
+					new String(readableName)
+				};
+				shortArguments = new String[] {
+					new String(shortReadableName)
+				};
 				break;
 			case ProblemReasons.Ambiguous :
 				id = IProblem.AmbiguousField;

org.eclipse.jdt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/problem/messages.properties

@@ -104,7 +104,7 @@
 68 = Too many array dimensions. Maximum is 255
 69 = The code of constructor {0}({1}) is exceeding the 65535 bytes limit
 70 = {0} cannot be resolved or is not a field
-71 = The field {1}.{0} is not visible
+71 = The field {0} is not visible
 72 = The field {0} is ambiguous
 73 = The field {0}.{1} is deprecated
 74 = Cannot make a static reference to the non-static field {0}

org.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/StaticImportTest.java

@@ -3559,4 +3559,30 @@ public class Sub extends Super {}
 		runner.expectedOutputString = "1";
 		runner.runConformTest();
 	}
+
+	// https://github.com/eclipse-jdt/eclipse.jdt.core/issues/4986
+	// Test that error message for inaccessible static import field is correctly formatted
+	public void testBug4986() {
+	    this.runNegativeTest(
+	        new String[] {
+	            "p/C.java",
+	            "package p;\n" +
+	            "import static p.C.f;\n" +
+	            "public class C {\n" +
+	            "    private static int f;\n" +
+	            "}\n"
+	        },
+	        "----------\n" +
+	        "1. ERROR in p\\C.java (at line 2)\n" +
+	        "\timport static p.C.f;\n" +
+	        "\t              ^^^^^\n" +
+	        "The field C.f is not visible\n" +
+	        "----------\n" +
+	        "2. WARNING in p\\C.java (at line 4)\n" +
+	        "\tprivate static int f;\n" +
+	        "\t                   ^\n" +
+	        "The value of the field C.f is not used\n" +
+	        "----------\n"
+	    );
+	}
 }