`org.eclipse.jdt.core.tests.model` not published

[datho7561]

I don't see org.eclipse.jdt.core.tests.model available under the i-builds for 4.40, but they're available for 4.39

[srikanth-sankaran]

See #5012 (comment)

[HannesWell]

All test projects intentionally have been removed from the Eclipse P2-repository:

• [Build] Remove test Plug-ins from Eclipse P2-repository eclipse-platform/eclipse.platform.releng.aggregator#3772

Can you explain why you are missing it specifically from the P2-repository?

[datho7561]

We're reusing the tests in https://github.com/eclipse-jdtls/eclipse.jdt.javac . I figured it was an unintentional removal, since the builder and compiler tests are still published in the i builds

[HannesWell]

We're reusing the tests in https://github.com/eclipse-jdtls/eclipse.jdt.javac .

Could you list what you are using from the test Plug-ins exactly?

I figured it was an unintentional removal, since the builder and compiler tests are still published in the i builds

Actually it was intentional to remove them, I just noticed afterwards that unfortunately some other projects within the SDK, PDE is among them, depend on them. So the quick solution for that problem was to add back the required test Plug-ins:

• Add back UI test-harness and required tests to Eclipse P2-repository eclipse-platform/eclipse.platform.releng.aggregator#3783 (comment)

But on the long run, the shared code should be moved into some of the test support/harness Plug-ins that will permanently be published. If you list what you need specifically, JDTLS can be considered from the beginning.

[datho7561]

Could you list what you are using from the test Plug-ins exactly?

The tests; org.eclipse.jdt.core.tests.model.RunCompletionModelTests, org.eclipse.jdt.core.tests.dom.RunConverterTests, org.eclipse.jdt.core.tests.model.RunJavaSearchTests. We're subclassing them in order to rerun them with our javac-based implementation of a bunch of JDT's internals.

I'm guessing this doesn't really fall under the "shared code" used by PDE. If it's intentional to not publish the tests, then we can look into modifying our build process in order to reuse those tests without relying on them being accessible from the p2 repo.

[HannesWell]

I'm guessing this doesn't really fall under the "shared code" used by PDE. If it's intentional to not publish the tests, then we can look into modifying our build process in order to reuse those tests without relying on them being accessible from the p2 repo.

Yes that sounds like a different scenario.
And yes it would be great if you could find other ways to achieve that (maybe by simply checking out the original tests from git?).
I don't know when the work will happen to remove the remaining inter-project dependencies on tests, but I hope that it will happen on the long run. So it would be better if you'd be prepared for that too.
Thanks in advance.

[datho7561]

We've addressed this on our end by modifying our build process. I think this can be closed

[akurtakov]

As per previous comment.