[Formatter] Handle Markdown in EnumDeclaration#5033
Merged
Conversation
SougandhS
changed the title
Member
Author
|
Hi @mateusz-matela, could you please check this PR too |
mateusz-matela
requested changes
Apr 30, 2026
Member
mateusz-matela
left a comment
mateusz-matela
left a comment
There was a problem hiding this comment.
And how about a unit test?
mateusz-matela
requested changes
May 6, 2026
Member
mateusz-matela
left a comment
mateusz-matela
left a comment
There was a problem hiding this comment.
and the unit test? do you intentionally skip it?
| EnumConstantDeclaration declaration = enumConstants.get(i); | ||
| if (declaration.getJavadoc() != null) | ||
| this.tm.firstTokenIn(declaration, TokenNameCOMMENT_JAVADOC).breakBefore(); | ||
| this.tm.firstTokenIn(declaration, ANY).breakBefore(); |
Member
There was a problem hiding this comment.
I was suggesting firstTokenIn(declaration.getJavadoc(), ANY) - it seems safer. Otherwise one may wonder if it's always true that the very first token in a declaration has to be the javadoc (and will it always be true in the future?)
SougandhS
force-pushed
the
EnumMarkdown
branch
2 times, most recently
from
4f97489 to
b289f84
Compare
Member
Author
Missed by mistake, added now 👍 (missed to commit earlier) |
SougandhS
force-pushed
the
EnumMarkdown
branch
4 times, most recently
from
1178536 to
b4217c7
Compare
This commit fixes the IOBE on formatting Markdown in Enum declaration part Fixes : eclipse-jdt#5032
mateusz-matela
approved these changes
May 11, 2026
Member
Author
|
Thank you @mateusz-matela ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the IOBE on formatting Markdown in Enum declaration part
Fixes : #5032
What it does
How to test
Author checklist