Provide constants for Markdown formatter#4336
Conversation
8c2598b to
177882e
Compare
mateusz-matela
left a comment
There was a problem hiding this comment.
So far all the settings are explicitly set in setDefaultSettings() and setJavaConventionsSettings(), I'd keep that way unless there's a good reason not to.
177882e to
15d4f01
Compare
Included in both |
15d4f01 to
40e5942
Compare
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
5f5f738 to
16eaead
Compare
|
Hi @HannesWell
|
I'm not completly sure as I don't know that project very well and looking at it's pom it seems to be a bit special. So I cannot really tell if this is common issue. Maybe @iloveeclipse can help here as he created large parts of that projects build config? Nevertheless I see a similar failure on the master branch of jdt.core and it looks again similar to the build problems I saw in the release preparation PR (but there I assumed it's a usual hick-up that can be investigated later): And last but not least I see the following error currently in the This is not the very same eclipse-project/tycho-module but at least also from this repo and I wonder if this is related. So TL;DR: I'm not sure yet, but I lean towards not ok. |
74c1964 to
0d36356
Compare
|
Also please make sure you have rebased tha change on latest master |
863ad6f to
a175349
Compare
a175349 to
542b4e0
Compare
This commit provides constant and fields for markdown formatting enablement & Enable markdown formatting via setDefaultSettings() & setJavaConventionsSettings() partial fix : eclipse-jdt#4335
542b4e0 to
d7463b5
Compare

This commit provides constant and fields for markdown formatting enablement
partial fix :
#4335
What it does
How to test
Author checklist