Normalize line separators in assertions#5061
Merged
trancexpress merged 1 commit intoMay 11, 2026
Merged
Conversation
Contributor
|
Thank you for taking a look! |
Contributor
|
Please update the commit message to what is in this PR description, e.g.: Then we can merge this. |
ASTConverterJavadocTest_18.testSnippetMultilineOnlyJavadoc5 Updated the test assertions to normalize line separators using \R → \n before comparison ensuring consistent behavior across all environments. Fixes: eclipse-jdt#5057
RagiGeorge
force-pushed
the
issue_fix_ASTConverterJavaDocTest
branch
from
018db9d to
86e4dc9
Compare
Contributor
|
Thank you @RagiGeorge ! I'll check the next I-build, hopefully the fail is gone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the failure reported in #5057, where
ASTConverterJavadocTest_18.testSnippetMultilineOnlyJavadoc5 was failing in Windows
Updated the test assertions to normalize line separators using \R → \n before comparison ensuring consistent behaviour across all environments.