Align inference resolution with javac by applying hints from Maurizio#5129
Merged
Merged
Conversation
This was referenced Jun 9, 2026
remove our own tweak from commit ad3653e
Improve the impl to cover one more issue + really make ivar-ivar dependencies bidirectional + consider all ivar-super bounds in ivar prioritization Opportunistically fine tune usage of same bounds: + only during regular inference: + record inverse of same-bounds for use by rankIVar() + only during record pattern inference: + workaround for inverse same-bounds in rankIVar() Still need to always use same-bounds during 2nd attempt of resolution Minor corrections (moving code lines up/down) Failures in + GenericsRegressionTest.test434118() + GenericsRegressionTest_9.testIssue4864() Fixes eclipse-jdt#4937
- GenericsRegressionTest.test434118 - GenericsRegressionTest_9.testIssue4864 + more propagation of isSoft flag (for consistency) + Revert part of commit dd34c06 from eclipse-jdt#4635: ARGUMENT_CONSTRAINTS_ARE_SOFT is back to false as recommended
- propagate failures during resolution of capture bounds
+ more documentation for JavacHasABug.JavacBug6573446 + new constant JavacHasABug.JavacBugIvarInterning + new constant JavacHasABug.JavacBug8297428 At this point GenericsRegressionTest_9 is ready to opt in to this mode
stephan-herrmann
force-pushed
the
issue5004
branch
from
d060245 to
bb820af
Compare
+ let unsuccessful glb proceed to 2nd attempt rather than failing
Contributor
Author
This was referenced Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consolidates and replaces #5004.
See individual commits from description.