Accept partially qualified member types in javadoc links #517#5191
Open
kamilkrzywanski wants to merge 1 commit into
Open
Accept partially qualified member types in javadoc links #517#5191kamilkrzywanski wants to merge 1 commit into
kamilkrzywanski wants to merge 1 commit into
Conversation
Package omission in member type references (e.g. {@link Map.Entry} with import java.util.Map) was only allowed within the same package. Allow it across packages as well, matching the Documentation Comment Specification and the standard doclet. Wrong outer types (e.g. Test.Inner when the type is Foo.Inner) are still rejected. Update related testBug222188a/testBug221539b expectations and add regression tests for issue 517. Fixes eclipse-jdt#517 Signed-off-by: Kamil Krzywannski <kamilkrzywanski01@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{@link Map.Entry}withimport java.util.Map) was only allowed within the same package.Test.Innerwhen the type isFoo.Inner) are still rejected.testBug222188a,testBug221539b) and add regression tests for issue 517.Fixes #517
Test plan
JavadocBugsTest(3682 tests) — all pass with the fixType.Membervia import updated to conformMap.Entrywith import, fully qualified, and wrong outer type still invalid