Wait for specific MethodExitEvent in MethodReturnValuesTests

MethodReturnValuesTests can receive multiple MethodExitEvent events, before calling EventWaiter.waitEvent().
As a result, the test can potentially make its checks on the wrong event, e.g. for: MainClass.triggerEvent()

This change ensures only the MethodExitEvent for the correct method is accepted by EventWaiter.

Fixes: #528

Author: trancexpress

org.eclipse.jdt.debug.jdi.tests/tests/org/eclipse/debug/jdi/tests/EventWaiter.java

@@ -116,8 +116,8 @@ public boolean modificationWatchpoint(ModificationWatchpointEvent event) {
 	 * Notify any object that is waiting for an event.
 	 */
 	synchronized protected void notifyEvent(Event event) {
-		notify();
 		fEvent = event;
+		notify();
 	}
 	/**
 	 * @see org.eclipse.debug.jdi.tests.EventListener#step(com.sun.jdi.event.StepEvent)

org.eclipse.jdt.debug.jdi.tests/tests/org/eclipse/debug/jdi/tests/MethodExitEventWaiter.java

@@ -0,0 +1,41 @@
+/*******************************************************************************
+ * Copyright (c) 2026 Simeon Andreev and others.
+ *
+ * This program and the accompanying materials
+ * are made available under the terms of the Eclipse Public License 2.0
+ * which accompanies this distribution, and is available at
+ * https://www.eclipse.org/legal/epl-2.0/
+ *
+ * SPDX-License-Identifier: EPL-2.0
+ *
+ * Contributors:
+ *     Simeon Andreev - initial API and implementation
+ *******************************************************************************/
+
+package org.eclipse.debug.jdi.tests;
+
+import com.sun.jdi.event.MethodExitEvent;
+import com.sun.jdi.request.EventRequest;
+/**
+ * Listen for ClassPrepareEvent for a specific class.
+ */
+public class MethodExitEventWaiter extends EventWaiter {
+	protected String fMethodName;
+
+	/**
+	 * Constructor
+	 */
+	public MethodExitEventWaiter(EventRequest request, boolean shouldGo, String methodName) {
+		super(request, shouldGo);
+		fMethodName = methodName;
+	}
+
+	@Override
+	public boolean methodExit(MethodExitEvent event) {
+		if (event.method().name().equals(fMethodName)) {
+			notifyEvent(event);
+			return fShouldGo;
+		}
+		return true;
+	}
+}

org.eclipse.jdt.debug.jdi.tests/tests/org/eclipse/debug/jdi/tests/MethodReturnValuesTests.java

@@ -95,7 +95,7 @@ public void testGetVoidMethodReturnValue() {
 				req = erm.createMethodExitRequest();
 				req.addClassFilter("org.eclipse.debug.jdi.tests.program.*");
 				req.enable();
-				waiter = new EventWaiter(req, true);
+				waiter = new MethodExitEventWaiter(req, true, "print");
 				fEventReader.addEventListener(waiter);
 				tref.resume();
 				event = (MethodExitEvent)waiter.waitEvent(10000);
@@ -137,7 +137,7 @@ public void testGetStringMethodReturnValue() {
 				req = erm.createMethodExitRequest();
 				req.addClassFilter("org.eclipse.debug.jdi.tests.program.*");
 				req.enable();
-				waiter = new EventWaiter(req, true);
+				waiter = new MethodExitEventWaiter(req, true, "foo");
 				fEventReader.addEventListener(waiter);
 				tref.resume();
 				event = (MethodExitEvent)waiter.waitEvent(5000);
@@ -179,7 +179,7 @@ public void testGetIntMethodReturnValue() {
 				req = erm.createMethodExitRequest();
 				req.addClassFilter("org.eclipse.debug.jdi.tests.program.*");
 				req.enable();
-				waiter = new EventWaiter(req, true);
+				waiter = new MethodExitEventWaiter(req, true, "getInt");
 				fEventReader.addEventListener(waiter);
 				tref.resume();
 				event = (MethodExitEvent)waiter.waitEvent(5000);
@@ -221,7 +221,7 @@ public void testGetBooleanMethodReturnValue() {
 				req = erm.createMethodExitRequest();
 				req.addClassFilter("org.eclipse.debug.jdi.tests.program.*");
 				req.enable();
-				waiter = new EventWaiter(req, true);
+				waiter = new MethodExitEventWaiter(req, true, "getBoolean");
 				fEventReader.addEventListener(waiter);
 				tref.resume();
 				event = (MethodExitEvent)waiter.waitEvent(5000);
@@ -263,7 +263,7 @@ public void testGetLongMethodReturnValue() {
 				req = erm.createMethodExitRequest();
 				req.addClassFilter("org.eclipse.debug.jdi.tests.program.*");
 				req.enable();
-				waiter = new EventWaiter(req, true);
+				waiter = new MethodExitEventWaiter(req, true, "getLong");
 				fEventReader.addEventListener(waiter);
 				tref.resume();
 				event = (MethodExitEvent)waiter.waitEvent(5000);