Skip to content

Commit 5c72761

Browse files
committed
Enable Step Filter by Default
Enable Step filter and few filter options enabled by default Fixes : #914
1 parent 5163f27 commit 5c72761

2 files changed

Lines changed: 11 additions & 3 deletions

File tree

org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/JDIDebugUIPreferenceInitializer.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
package org.eclipse.jdt.internal.debug.ui;
1717

1818
import org.eclipse.core.runtime.preferences.AbstractPreferenceInitializer;
19+
import org.eclipse.debug.ui.DebugUITools;
1920
import org.eclipse.debug.ui.IDebugUIConstants;
2021
import org.eclipse.jdt.debug.ui.IJavaDebugUIConstants;
2122
import org.eclipse.jface.preference.IPreferenceStore;
@@ -38,7 +39,14 @@ public void initializeDefaultPreferences() {
3839
store.setDefault(IJDIPreferencesConstants.PREF_ALERT_UNABLE_TO_INSTALL_BREAKPOINT, true);
3940
store.setDefault(IJDIPreferencesConstants.PREF_PROMPT_BEFORE_MODIFYING_FINAL_FIELDS, true);
4041
store.setDefault(IJDIPreferencesConstants.PREF_PROMPT_DELETE_CONDITIONAL_BREAKPOINT, true);
42+
43+
44+
DebugUITools.setUseStepFilters(true);
4145
store.setDefault(IJDIPreferencesConstants.PREF_STATEMENT_LEVEL_STEPPING, true);
46+
store.setDefault(IJDIPreferencesConstants.PREF_FILTER_SYNTHETICS, true);
47+
store.setDefault(IJDIPreferencesConstants.PREF_STEP_THRU_FILTERS, true);
48+
store.setDefault(IJDIPreferencesConstants.PREF_FILTER_GETTERS, true);
49+
store.setDefault(IJDIPreferencesConstants.PREF_FILTER_SETTERS, true);
4250

4351
store.setDefault(IJDIPreferencesConstants.PREF_SHOW_QUALIFIED_NAMES, false);
4452

org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/JavaStepFilterPreferencePage.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ public void init(IWorkbench workbench) {}
8787
*/
8888
private void createStepFilterPreferences(Composite parent) {
8989
Composite container = SWTFactory.createComposite(parent, parent.getFont(), 2, 1, GridData.FILL_BOTH, 0, 0);
90-
fUseStepFiltersButton = SWTFactory.createCheckButton(container, DebugUIMessages.JavaStepFilterPreferencePage__Use_step_filters, null, DebugUITools.isUseStepFilters(), 2);
90+
fUseStepFiltersButton = SWTFactory.createCheckButton(container, DebugUIMessages.JavaStepFilterPreferencePage__Use_step_filters, null, true, 2);
9191
fUseStepFiltersButton.addSelectionListener(new SelectionListener() {
9292
@Override
9393
public void widgetSelected(SelectionEvent e) {
@@ -189,8 +189,8 @@ public boolean performOk() {
189189
@Override
190190
protected void performDefaults() {
191191
// Cannot use DebugUITools.isUseStepFilters() as this not give the default value, no API from Platform to get the default value
192-
fUseStepFiltersButton.setSelection(false);
193-
setPageEnablement(false);
192+
fUseStepFiltersButton.setSelection(true);
193+
setPageEnablement(true);
194194
fFilterSyntheticButton.setSelection(getPreferenceStore().getDefaultBoolean(IJDIPreferencesConstants.PREF_FILTER_SYNTHETICS));
195195
fFilterStaticButton.setSelection(getPreferenceStore().getDefaultBoolean(IJDIPreferencesConstants.PREF_FILTER_STATIC_INITIALIZERS));
196196
fFilterConstructorButton.setSelection(getPreferenceStore().getDefaultBoolean(IJDIPreferencesConstants.PREF_FILTER_CONSTRUCTORS));

0 commit comments

Comments
 (0)