Skip to content

Commit 9ac18a7

Browse files
authored
Update "Add Detail Formatter" messages (#636)
- Use "..." suffix for a label of a button that opens a dialog - Make "Add Type/Primitive" dialogs more similar
1 parent 3bb53aa commit 9ac18a7

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/DebugUIMessages.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -311,6 +311,7 @@ public class DebugUIMessages extends NLS {
311311
public static String DetailFormatterDialog_Detail_formatter__code_snippet__1;
312312
public static String DetailFormatterDialog_17;
313313
public static String DetailFormatterPrimitiveSelect;
314+
public static String DetailFormatterPrimitiveSelectionTitle;
314315
public static String DetailFormatterPrimitiveSelectionLabel;
315316

316317
public static String No_type_with_the_given_name_found_in_the_workspace__1;

org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/DebugUIMessages.properties

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -250,14 +250,15 @@ DetailFormatterDialog_Could_not_open_type_selection_dialog_for_detail_formatters
250250
DetailFormatterDialog_Select_type_8=Select Type
251251
DetailFormatterDialog_Select_type_9=Browse Type
252252
DetailFormatterDialog_Select_type_10=In order to browse a type, a project needs to be present and accessible.
253-
DetailFormatterDialog_Select_a_type_to_format_when_displaying_its_detail_9=&Select a type to format when displaying its detail:
253+
DetailFormatterDialog_Select_a_type_to_format_when_displaying_its_detail_9=&Select a type to format when displaying its details:
254254
DetailFormatterDialog_Edit_Detail_Formatter_1=Edit Detail Formatter
255255
DetailFormatterDialog_Add_Detail_Formatter_2=Add Detail Formatter
256256
DetailFormatterDialog_Associated_code_must_not_be_empty_3=Detail formatter code snippet must not be empty
257257
DetailFormatterDialog_Detail_formatter__code_snippet__1=Detail formatter &code snippet:
258258
DetailFormatterDialog_17=Detail formatter &code snippet ({0} for code assist):
259-
DetailFormatterPrimitiveSelect=Select primitives
260-
DetailFormatterPrimitiveSelectionLabel=Choose a primitive
259+
DetailFormatterPrimitiveSelect=Select &Primitive...
260+
DetailFormatterPrimitiveSelectionTitle=Select Primitive
261+
DetailFormatterPrimitiveSelectionLabel=&Select a primitive or an array of primitives to format when displaying its details:
261262

262263
No_type_with_the_given_name_found_in_the_workspace__1=No type with the given name found in the workspace.
263264
JavaDetailFormattersManager_Detail_formatter_error___1=Detail formatter error:

org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/DetailFormatterDialog.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -351,7 +351,7 @@ private void selectType() {
351351
private void selectPrimitiveType() {
352352
Shell shell = getShell();
353353
ListDialog listDialog = new ListDialog(shell);
354-
listDialog.setTitle(DebugUIMessages.DetailFormatterDialog_Select_type_8);
354+
listDialog.setTitle(DebugUIMessages.DetailFormatterPrimitiveSelectionTitle);
355355
listDialog.setMessage(DebugUIMessages.DetailFormatterPrimitiveSelectionLabel);
356356
listDialog.setInput(getPrimitiveTypes().toArray());
357357
listDialog.setContentProvider(ArrayContentProvider.getInstance());

0 commit comments

Comments
 (0)