Close HotCodeReplace dialog automatically when process ends (#630)

* Close popup on thread termination via DebugEventListener

* Version bump(s) for 4.36 stream

---------

Co-authored-by: eclipse-releng-bot <98035380+eclipse-releng-bot@users.noreply.github.com>
Co-authored-by: Eclipse JDT Bot <jdt-bot@eclipse.org>

Author: 3 people

org.eclipse.jdt.debug.ui/META-INF/MANIFEST.MF

@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.jdt.debug.ui; singleton:=true
-Bundle-Version: 3.14.0.qualifier
+Bundle-Version: 3.14.100.qualifier
 Bundle-Activator: org.eclipse.jdt.internal.debug.ui.JDIDebugUIPlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin

org.eclipse.jdt.debug.ui/pom.xml

@@ -18,7 +18,7 @@
   </parent>
   <groupId>org.eclipse.jdt</groupId>
   <artifactId>org.eclipse.jdt.debug.ui</artifactId>
-  <version>3.14.0-SNAPSHOT</version>
+  <version>3.14.100-SNAPSHOT</version>
   <packaging>eclipse-plugin</packaging>
   <properties>
   	<defaultSigning-excludeInnerJars>true</defaultSigning-excludeInnerJars>

org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/HotCodeReplaceErrorDialog.java

@@ -14,11 +14,15 @@
 package org.eclipse.jdt.internal.debug.ui;
 
 import org.eclipse.core.runtime.IStatus;
+import org.eclipse.debug.core.DebugEvent;
 import org.eclipse.debug.core.DebugException;
+import org.eclipse.debug.core.DebugPlugin;
+import org.eclipse.debug.core.IDebugEventSetListener;
 import org.eclipse.debug.core.ILaunch;
 import org.eclipse.debug.core.ILaunchConfiguration;
 import org.eclipse.debug.core.model.IDebugTarget;
 import org.eclipse.debug.ui.DebugUITools;
+import org.eclipse.jdt.internal.debug.core.model.JDIThread;
 import org.eclipse.jface.dialogs.IDialogConstants;
 import org.eclipse.jface.preference.IPreferenceStore;
 import org.eclipse.osgi.util.NLS;
@@ -29,14 +33,15 @@
 import org.eclipse.swt.layout.GridData;
 import org.eclipse.swt.widgets.Button;
 import org.eclipse.swt.widgets.Composite;
+import org.eclipse.swt.widgets.Display;
 import org.eclipse.swt.widgets.Shell;
 
 /**
  * An error dialog reporting a problem with a debug
  * target which gives the user the option to continue
  * or terminate/disconnect or restart the target.
  */
-public class HotCodeReplaceErrorDialog extends ErrorDialogWithToggle {
+public class HotCodeReplaceErrorDialog extends ErrorDialogWithToggle implements IDebugEventSetListener {
 
 	protected IDebugTarget target;
 	// The IDs of the buttons. Set to the sum of the other possible IDs generated by
@@ -53,6 +58,7 @@ public class HotCodeReplaceErrorDialog extends ErrorDialogWithToggle {
 	public HotCodeReplaceErrorDialog(Shell parentShell, String dialogTitle, String message, IStatus status, String preferenceKey, String toggleMessage, String toggleMessage2, IPreferenceStore store, IDebugTarget target) {
 		super(parentShell, dialogTitle, message, status, preferenceKey, toggleMessage, toggleMessage2, store);
 		this.target = target;
+		DebugPlugin.getDefault().addDebugEventListener(this);
 	}
 
 	/* (non-Javadoc)
@@ -149,4 +155,16 @@ public void run() {
 			super.buttonPressed(id, target);
 		}
 	}
+
+	@Override
+	public void handleDebugEvents(DebugEvent[] events) {
+		for (DebugEvent event : events) {
+			if (event.getSource() instanceof JDIThread de) {
+				if (de.isTerminated()) {
+					Display.getDefault().asyncExec(() -> this.close());
+				}
+			}
+		}
+
+	}
 }