CI-build time exceeds the timeout

[stephan-herrmann]

Since recently many build jobs for jdt.debug are being aborted at the timeout of 40 minutes, while previously a typical time to completion was below 30 minutes.

The list on https://ci.eclipse.org/jdt/job/eclipse.jdt.debug-github/job/master/ indicates that build times went up after #692 - already the PR build was aborted - but I have no idea if that change possibly brought such performance regression or whether all this is based only on "bad weather" on our build infra.

Anyone have a guess?

@SougandhS @subyssurendran666 @HannesWell @jarthana

[stephan-herrmann]

Should we increase the timeout on jenkins just for now?

[SougandhS]

Should we increase the timeout on jenkins just for now?

Maybe infra issues. But we can try by increasing timeout and lets see.

[iloveeclipse]

Most likely this is a side effect of eclipse-platform/eclipse.platform.ui#3025 & waitForJobs() waiting for reconciler jobs now.

[iloveeclipse]

Most likely this is a side effect

I've checked the console, it is pretty clear that this is the root cause:
https://ci.eclipse.org/jdt/job/eclipse.jdt.debug-github/job/master/6/console

!MESSAGE [testListenersOnRuntimeError] Some job is still running or waiting to run: 
14:19:45  'org.eclipse.jdt.internal.ui.text.JavaReconciler(70428)'/org.eclipse.jface.text.reconciler.AbstractReconciler$BackgroundThread
14:19:45  thread info: "Worker-9: org.eclipse.jdt.internal.ui.text.JavaReconciler" prio=5 Id=144 TIMED_WAITING on org.eclipse.jface.text.reconciler.DirtyRegionQueue@7a9888ce
14:19:45  	at java.base@24/java.lang.Object.wait0(Native Method)
14:19:45  	-  waiting on org.eclipse.jface.text.reconciler.DirtyRegionQueue@7a9888ce
14:19:45  	at java.base@24/java.lang.Object.wait(Object.java:389)
14:19:45  	at org.eclipse.jface.text.reconciler.AbstractReconciler.delay(AbstractReconciler.java:599)
14:19:45  	at org.eclipse.jface.text.reconciler.AbstractReconciler$BackgroundThread.run(AbstractReconciler.java:190)
14:19:45  	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)

[iloveeclipse]

There are usually two issues:

1. The test open and does NOT close editors (who cares to cleanup properly?). Now if editor is opened, reconciler job will keep running and on teardown org.eclipse.jdt.debug.tests.TestUtil.cleanUp(String) will wait for it.
2. The test expects some result from some action that triggers one or few jobs, so it waits for jobs to proceed and now it will wait longer if the editor is opened.

I will check whether I can find and fix bad tests and also fix the generic utilities we use...

[iloveeclipse]

1305 matches for Some job is still running or waiting to run /org.eclipse.jface.text.reconciler.AbstractReconciler$BackgroundThread in the log...

[iloveeclipse]

I've pushed first attempt here: #722

Will go for a lunch and check afterwards whether this is better or not.