Skip to content

Close HotCodeReplace dialog automatically when process ends#630

Merged
SougandhS merged 2 commits intoeclipse-jdt:masterfrom
subyssurendran666:Close_HotCodeReplace_dialog_automatically_when_process_ends_596
Mar 5, 2025
Merged

Close HotCodeReplace dialog automatically when process ends#630
SougandhS merged 2 commits intoeclipse-jdt:masterfrom
subyssurendran666:Close_HotCodeReplace_dialog_automatically_when_process_ends_596

Conversation

@subyssurendran666
Copy link
Copy Markdown
Contributor

@subyssurendran666 subyssurendran666 commented Mar 5, 2025

What it does

Implemented DebugEventListener to monitor debugging events and ensured the popup automatically closes when the thread has successfully terminated.

This PR closes: #596

How to test

Author checklist

@eclipse-jdt-bot
Copy link
Copy Markdown
Contributor

eclipse-jdt-bot commented Mar 5, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

org.eclipse.jdt.debug.ui/META-INF/MANIFEST.MF
org.eclipse.jdt.debug.ui/pom.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 6c6c6f30b94514d1dafde071bebe7f4dd5f86808 Mon Sep 17 00:00:00 2001
From: Eclipse JDT Bot <jdt-bot@eclipse.org>
Date: Wed, 5 Mar 2025 05:05:00 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/org.eclipse.jdt.debug.ui/META-INF/MANIFEST.MF b/org.eclipse.jdt.debug.ui/META-INF/MANIFEST.MF
index b6cb9e94b..16073a15c 100644
--- a/org.eclipse.jdt.debug.ui/META-INF/MANIFEST.MF
+++ b/org.eclipse.jdt.debug.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.jdt.debug.ui; singleton:=true
-Bundle-Version: 3.14.0.qualifier
+Bundle-Version: 3.14.100.qualifier
 Bundle-Activator: org.eclipse.jdt.internal.debug.ui.JDIDebugUIPlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
diff --git a/org.eclipse.jdt.debug.ui/pom.xml b/org.eclipse.jdt.debug.ui/pom.xml
index 9716cf342..6db08dc64 100644
--- a/org.eclipse.jdt.debug.ui/pom.xml
+++ b/org.eclipse.jdt.debug.ui/pom.xml
@@ -18,7 +18,7 @@
   </parent>
   <groupId>org.eclipse.jdt</groupId>
   <artifactId>org.eclipse.jdt.debug.ui</artifactId>
-  <version>3.14.0-SNAPSHOT</version>
+  <version>3.14.100-SNAPSHOT</version>
   <packaging>eclipse-plugin</packaging>
   <properties>
   	<defaultSigning-excludeInnerJars>true</defaultSigning-excludeInnerJars>
-- 
2.48.1

Further information are available in Common Build Issues - Missing version increments.

@SougandhS
Copy link
Copy Markdown
Member

Tested your PR now. works well 👍

@subyssurendran666 subyssurendran666 force-pushed the Close_HotCodeReplace_dialog_automatically_when_process_ends_596 branch from d38a05d to 67d9e4b Compare March 5, 2025 04:50
@SougandhS SougandhS added the enhancement New feature or request label Mar 5, 2025
@subyssurendran666 subyssurendran666 force-pushed the Close_HotCodeReplace_dialog_automatically_when_process_ends_596 branch from 968a7fa to eb6bef6 Compare March 5, 2025 04:59
@subyssurendran666 subyssurendran666 force-pushed the Close_HotCodeReplace_dialog_automatically_when_process_ends_596 branch from 6c584b8 to 36e133e Compare March 5, 2025 05:03
@subyssurendran666
Copy link
Copy Markdown
Contributor Author

subyssurendran666 commented Mar 5, 2025

Done interactive rebase with the previous changes, ie version bump, along with this PR.

@mpalat
Copy link
Copy Markdown

mpalat commented Mar 5, 2025

@SougandhS @subyssurendran666 Please squash and merge

@SougandhS SougandhS merged commit dde4425 into eclipse-jdt:master Mar 5, 2025
@SougandhS
Copy link
Copy Markdown
Member

Thanks @subyssurendran666 👍

@iloveeclipse
Copy link
Copy Markdown
Member

FYI, this change caused regression #792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Close HotCodeReplace dialog automatically when process ends

6 participants