Close HotCodeReplace dialog automatically when process ends#630
Merged
SougandhS merged 2 commits intoeclipse-jdt:masterfrom Mar 5, 2025
Conversation
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Member
|
Tested your PR now. works well 👍 |
d38a05d to
67d9e4b
Compare
968a7fa to
eb6bef6
Compare
6c584b8 to
36e133e
Compare
Contributor
Author
|
Done interactive rebase with the previous changes, ie version bump, along with this PR. |
SougandhS
approved these changes
Mar 5, 2025
|
@SougandhS @subyssurendran666 Please squash and merge |
Member
|
Thanks @subyssurendran666 👍 |
Member
|
FYI, this change caused regression #792 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Implemented DebugEventListener to monitor debugging events and ensured the popup automatically closes when the thread has successfully terminated.
This PR closes: #596
How to test
Author checklist