Merged
Conversation
Member
|
Could you please include some before and after screenshot ? |
Contributor
Author
|
There is not much changed visibly, previously when you opened the dialog the current imports were not visible, but after the fixes, it become visible again. |
Member
im having some difficulties in reproducing the same |
Contributor
Author
not-working-dialog.webm |
Member
Got it. thanks 👍 |
Member
|
Could you please update the branch ? |
gzsombor
force-pushed
the
select-imports-dialog
branch
from
032120e to
47819c5
Compare
SougandhS
approved these changes
Mar 19, 2025
This is instead of saving the user input didn't do anything, because it was used the incorrect 'imports' not the user provided 'filters'.
gzsombor
force-pushed
the
select-imports-dialog
branch
from
47819c5 to
2dba467
Compare
Contributor
Author
|
The branch is up to date and the build is green! |
Member
|
Thank you for contributing @gzsombor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is instead of saving the user input didn't do anything, because it was used the incorrect 'imports' not the user provided 'filters'
What it does
In the Java snippet editor previously the import dialog didn't work properly, it didn't save the user provided package names, this patch fixes it.
How to test
Author checklist