Skip to content

Update "Add Detail Formatter" messages#636

Merged
SougandhS merged 1 commit intoeclipse-jdt:masterfrom
howlger:patch-1
Mar 21, 2025
Merged

Update "Add Detail Formatter" messages#636
SougandhS merged 1 commit intoeclipse-jdt:masterfrom
howlger:patch-1

Conversation

@howlger
Copy link
Copy Markdown
Contributor

@howlger howlger commented Mar 8, 2025

  • Use "..." suffix for a label of a button that opens a dialog
  • Make "Add Type/Primitive" dialogs more similar

@howlger
Copy link
Copy Markdown
Contributor Author

howlger commented Mar 8, 2025

The title of the dialog to select a primitive is Select Type instead of Select Primitive which needs also to be fixed.

Copy link
Copy Markdown
Member

@SougandhS SougandhS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of the dialog to select a primitive is Select Type instead of Select Primitive which needs also to be fixed.

You may want to add an additional entry in DebugUIMessages and include it in the setTitle() property of org.eclipse.jdt.internal.debug.ui.DetailFormatterDialog.selectPrimitiveType().listDialog

@howlger
Copy link
Copy Markdown
Contributor Author

howlger commented Mar 21, 2025

The title of the dialog to select a primitive is Select Type instead of Select Primitive which needs also to be fixed.

You may want to add an additional entry in DebugUIMessages and include it in the setTitle() property of org.eclipse.jdt.internal.debug.ui.DetailFormatterDialog.selectPrimitiveType().listDialog

Thanks. Done.

@SougandhS
Copy link
Copy Markdown
Member

Could you please update the branch

- Use "..." suffix for a label of a button that opens a dialog
- Make "Add Type/Primitive" dialogs more similar
Copy link
Copy Markdown
Member

@SougandhS SougandhS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat now!

@SougandhS SougandhS merged commit 9ac18a7 into eclipse-jdt:master Mar 21, 2025
10 checks passed
@SougandhS
Copy link
Copy Markdown
Member

Thank you @howlger for contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants