Skip to content

Navigate to variable declaration from variable view#642

Merged
SougandhS merged 1 commit intoeclipse-jdt:masterfrom
subyssurendran666:navigate_to_local_variable_while_debug
Mar 24, 2025
Merged

Navigate to variable declaration from variable view#642
SougandhS merged 1 commit intoeclipse-jdt:masterfrom
subyssurendran666:navigate_to_local_variable_while_debug

Conversation

@subyssurendran666
Copy link
Copy Markdown
Contributor

@subyssurendran666 subyssurendran666 commented Mar 17, 2025

What it does

All necessary discussions so far have been added to the parent ticket.

This PR closes #640

How to test

Steps

  1. Screenshot 2025-03-18 at 8 14 36 AM

Right click on the variable in the variables view while on debug mode. A new option have beed added("Open local variable Navigation)
2. Screenshot 2025-03-18 at 8 15 58 AM
Once it selected, the selected variable highlighted.
3. Screenshot 2025-03-18 at 8 17 13 AM
The "Open local variable navigation" option would not available for unwanted items.

Author checklist

@subyssurendran666
Copy link
Copy Markdown
Contributor Author

@SougandhS could you please review this PR?

@SougandhS
Copy link
Copy Markdown
Member

Please update the PR description and steps to test

Comment thread org.eclipse.jdt.debug.ui/plugin.xml Outdated
@subyssurendran666
Copy link
Copy Markdown
Contributor Author

Please update the PR description and steps to test

Done

@SougandhS
Copy link
Copy Markdown
Member

Hi @subyssurendran666 ,On testing the PR i found 3 issues

  • Context menu option for navigation is not showing for static members
image
  • If I select any other frame other than top frame it wont navigate
image
  • Similar to 2nd if its on different thread then also it wont work
image

@subyssurendran666 subyssurendran666 force-pushed the navigate_to_local_variable_while_debug branch from 77b8f74 to 7752d38 Compare March 20, 2025 18:28
@subyssurendran666
Copy link
Copy Markdown
Contributor Author

Hi @subyssurendran666 ,On testing the PR i found 3 issues

  • Context menu option for navigation is not showing for static members
image * If I select any other frame other than top frame it wont navigate image * Similar to 2nd if its on different thread then also it wont work image

These three scenarios handled.

@SougandhS SougandhS added the enhancement New feature or request label Mar 21, 2025
Comment thread org.eclipse.jdt.debug.ui/plugin.properties Outdated
Comment thread org.eclipse.jdt.debug.ui/plugin.properties Outdated
@subyssurendran666 subyssurendran666 force-pushed the navigate_to_local_variable_while_debug branch from 7752d38 to c2b44cd Compare March 24, 2025 02:05
@subyssurendran666 subyssurendran666 force-pushed the navigate_to_local_variable_while_debug branch from c2b44cd to 523b086 Compare March 24, 2025 04:15
Copy link
Copy Markdown
Member

@SougandhS SougandhS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash all commits to one.

This commit adds context menu in variables view to highlight variable's
declaration in the source editor.

Fixes : eclipse-jdt#640
@subyssurendran666 subyssurendran666 force-pushed the navigate_to_local_variable_while_debug branch from 523b086 to f08f600 Compare March 24, 2025 05:09
@SougandhS SougandhS merged commit 4d17b65 into eclipse-jdt:master Mar 24, 2025
11 checks passed
@SougandhS
Copy link
Copy Markdown
Member

Thank you @subyssurendran666 for your contribution ✨

@SougandhS SougandhS added the noteworthy Noteworthy feature label Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request noteworthy Noteworthy feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Navigate to variable declaration from variable view

2 participants