Skip to content

Remove Debug listener on HCR popup close#646

Merged
SougandhS merged 1 commit intoeclipse-jdt:masterfrom
SougandhS:HCR_lisneter_remover
Mar 21, 2025
Merged

Remove Debug listener on HCR popup close#646
SougandhS merged 1 commit intoeclipse-jdt:masterfrom
SougandhS:HCR_lisneter_remover

Conversation

@SougandhS
Copy link
Copy Markdown
Member

@SougandhS SougandhS commented Mar 19, 2025

Fixes : https://github.com/eclipse-jdt/eclipse.jdt.debug/pull/630/files#r2003358448

Remove debug event listener when HCR failure dialog is closed after thread termination

What it does

How to test

Author checklist

@SougandhS SougandhS force-pushed the HCR_lisneter_remover branch 2 times, most recently from 76bddde to ad23569 Compare March 19, 2025 14:18
@SougandhS
Copy link
Copy Markdown
Member Author

Cc : @iloveeclipse

@SougandhS SougandhS changed the title Remove Debug listener on HCR pop close Remove Debug listener on HCR popup close Mar 19, 2025
@SougandhS SougandhS force-pushed the HCR_lisneter_remover branch from ad23569 to a4aec66 Compare March 19, 2025 15:09
@SougandhS SougandhS requested a review from iloveeclipse March 19, 2025 15:11
@SougandhS SougandhS force-pushed the HCR_lisneter_remover branch 2 times, most recently from 54a87fc to 60b49f5 Compare March 20, 2025 07:12
@SougandhS SougandhS force-pushed the HCR_lisneter_remover branch from 60b49f5 to 87148a4 Compare March 20, 2025 12:08
@SougandhS SougandhS requested a review from iloveeclipse March 21, 2025 10:21
@SougandhS SougandhS force-pushed the HCR_lisneter_remover branch from 87148a4 to 4c33f69 Compare March 21, 2025 10:21
Added launch check prior pop-up close and Remove debug event listener
when HCR failure dialog is closed after thread termination
@SougandhS SougandhS force-pushed the HCR_lisneter_remover branch from 4c33f69 to 596b770 Compare March 21, 2025 10:43
@SougandhS SougandhS added the bug Something isn't working label Mar 21, 2025
@SougandhS SougandhS merged commit 7af2360 into eclipse-jdt:master Mar 21, 2025
11 checks passed
@SougandhS
Copy link
Copy Markdown
Member Author

Thank you @iloveeclipse

@SougandhS SougandhS deleted the HCR_lisneter_remover branch September 9, 2025 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants