Closed
Conversation
21 tasks
Member
|
Build failures are due to https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/5892 |
SougandhS
requested changes
Apr 28, 2025
| */ | ||
| public class ClasspathShortener implements IProcessTempFileCreator { | ||
| private static final String CLASSPATH_ENV_VAR_PREFIX = "CLASSPATH="; //$NON-NLS-1$ | ||
| public static final int ARG_MAX_FREEBSD = 2097152; |
Member
There was a problem hiding this comment.
ARG_MAX_FREEBSD & ARG_MAX_LINUX have identical values, can you reuse ARG_MAX_LINUX for freeBSD ?
| } | ||
|
|
||
| protected int getMaxArgLength() { | ||
| if (os.equals(Platform.OS_FREEBSD)) { |
Member
There was a problem hiding this comment.
Looks similar to if (os.equals(Platform.OS_LINUX)) block, as both are same, I would recommend something like
if (os.equals(Platform.OS_LINUX) || os.equals(Platform.OS_FREEBSD)) { .... }
SougandhS
requested changes
Apr 28, 2025
| public static final int ARG_MAX_LINUX = 2097152; | ||
| public static final int ARG_MAX_WINDOWS = 32767; | ||
| public static final int ARG_MAX_MACOS = 262144; | ||
| public static final int MAX_ARG_STRLEN_FREEBSD = 131072; |
Member
There was a problem hiding this comment.
Possible to reuse MAX_ARG_STRLEN_LINUX ?
SougandhS
force-pushed
the
support_freebsd_aarch64_x86_64
branch
from
1857a53 to
e0a55ea
Compare
Author
|
Closing as there isn't a viable path forward for FreeBSD. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of eclipse-platform/eclipse.platform.releng.aggregator#2959
Author checklist