Don't use Display.syncExec() for refresh in RuntimeClasspathViewer#681
Merged
iloveeclipse merged 1 commit intoeclipse-jdt:masterfrom May 1, 2025
Merged
Don't use Display.syncExec() for refresh in RuntimeClasspathViewer#681iloveeclipse merged 1 commit intoeclipse-jdt:masterfrom
iloveeclipse merged 1 commit intoeclipse-jdt:masterfrom
Conversation
basilevs
suggested changes
Apr 24, 2025
basilevs
reviewed
Apr 24, 2025
The listener may be called from a background thread that already holds some locks. To refresh RuntimeClasspathViewer UI in the current case, syncExec is not needed, asyncExec is enough and it would not acquire the UI lock from an unknown thread. Fixes eclipse-jdt#672
Member
Author
|
Thanks @basilevs, I've updated patch. |
basilevs
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The listener may be called from a background thread that already holds some locks. To refresh RuntimeClasspathViewer UI in the current case, syncExec is not needed, asyncExec is enough and it would not acquire the UI lock from an unknown thread.
Fixes #672