Disable on hit for Breakpoints#682
Merged
SougandhS merged 1 commit intoeclipse-jdt:masterfrom May 7, 2025
Merged
Conversation
SougandhS
requested changes
Apr 25, 2025
SougandhS
requested changes
Apr 25, 2025
Member
SougandhS
left a comment
SougandhS
left a comment
There was a problem hiding this comment.
For Triggerpoints we can keep this option disabled
SougandhS
requested changes
Apr 25, 2025
Member
There was a problem hiding this comment.
I noticed if I set disable on hit on one breakpoint, it is affect to all breakpoints. You may want to initialize fDisableOnHit.setSelection() inside org.eclipse.jdt.internal.debug.ui.breakpoints.StandardJavaBreakpointEditor.setBreakpoint(IJavaBreakpoint)
Member
|
As this is a new feature pls provide a unit test if possible. |
subyssurendran666
force-pushed
the
disable_on_hit_for_breakpoint_680
branch
2 times, most recently
from
b9241b9 to
75c744a
Compare
Member
|
Thanks for the tests! |
Contributor
Author
Done. Now the hit point will be disabled if the user switches to the trigger point. |
SougandhS
force-pushed
the
disable_on_hit_for_breakpoint_680
branch
2 times, most recently
from
daabc12 to
e26098d
Compare
Disable on Hit feature is now supported for all breakpoints except trigger points Fixes: eclipse-jdt#680
SougandhS
force-pushed
the
disable_on_hit_for_breakpoint_680
branch
from
e26098d to
17fbc6e
Compare
Member
|
Thanks 🎉 |
SougandhS
added a commit
that referenced
this pull request
May 21, 2025
* Touch bundles affected by compiler changes See eclipse-platform/eclipse.platform.releng.aggregator#2995 * Don't use Display.syncExec() for refresh in RuntimeClasspathViewer The listener may be called from a background thread that already holds some locks. To refresh RuntimeClasspathViewer UI in the current case, syncExec is not needed, asyncExec is enough and it would not acquire the UI lock from an unknown thread. Fixes #672 * Force qualifier update to fix build failure eclipse-platform/eclipse.platform.releng.aggregator#3006 * [Build] Migrate to new tycho-apitools log and list maven issues Also make sure the issues are published even in case of a failed build, as otherwise they are not visualized and improve order of post-actions. Additionally record maven issues, but don't add a quality-gate for them. * Fixed Trigger point disabled automatically (#667) The trigger point is being disabled during debugging when a conditional breakpoint is hit. Fixes: #546 * Regression fix in (#688) #608 Invalid links generated with multiple spaces Fixes : #687 * Disable on hit for Breakpoints (#682) Disable on Hit feature is now supported for all breakpoints except trigger points Fixes: #680 * Add SVGs to org.eclipse.jdt.debug Bundles (#678) * add all svgs to eclipse.jdt.debug bundles This commit adds SVGs for all icons in the bundle `org.eclipse.jdt.debug.ui` except for the following as these are not available as SVG yet: obj16/groupedframe.svg obj16/javastacktrace_console.svg obj16/jexcept_obj.svg Referenced icons from `org.eclipse.debug.ui` were also changed to SVG as these already exist. Please note that `JDT Debug` also has the following missing SVGs in other bundles: org.eclipse.jdt.launching.ui.macosx/icons/full/ctool16/exportappbundle_wiz.xvg org.eclipse.jdt.launching.ui.macosx/icons/full/wizban/exportapp_wiz.xvg org.eclipse.jdt.debug.setup - JDTDebugConfiguration.setup uses the following link: `https://www.eclipse.org/downloads/images/committers.png` * Remove explicit disabled icons from org.eclipse.jdt.debug.ui Use on-the-fly-generated disabled version of SVG-rasterized icons instead. Hardcoded disabled entries in class `JavaDebugImages` can't be removed as other classes depend on them. These entries use a specific disabled icon variant which also exists as SVG. * Modify existing behaviour of opening Exception Stack trace (#698) Add option for navigating to exception types in editor instead of directly creating or modifying exception breakpoints on clicking exception types from console Fix: #670 * Additional handling for Disable on Hit (#699) This commit moves disable on hit check to JDIThread class + uncheck the option when disabled * Method Breakpoint does not recognised when set at end of a method (#700) This PR fixes the issue where breakpoints set at method closing braces did not created exit method breakpoints Fix: #697 --------- Co-authored-by: Andrey Loskutov <loskutov@gmx.de> Co-authored-by: Ed Merks <ed.merks@gmail.com> Co-authored-by: Hannes Wellmann <wellmann.hannes1@gmx.net> Co-authored-by: Suby S Surendran <suby.surendran@ibm.com> Co-authored-by: Michael Bangas <102024826+Michael5601@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Disable on Hit" option has been implemented for all breakpoints except trigger points. This means that when a breakpoint (other than a trigger point) is hit during program execution, it can now be automatically disabled based on this setting
Fixes: #680
What it does
How to test
Author checklist