Skip to content

Modify existing behaviour of opening Exception Stack trace#698

Merged
SougandhS merged 1 commit intoeclipse-jdt:masterfrom
subyssurendran666:Modify_existing_behaviour_of_opening_Exception_Stack_trace_670
May 14, 2025
Merged

Modify existing behaviour of opening Exception Stack trace#698
SougandhS merged 1 commit intoeclipse-jdt:masterfrom
subyssurendran666:Modify_existing_behaviour_of_opening_Exception_Stack_trace_670

Conversation

@subyssurendran666
Copy link
Copy Markdown
Contributor

@subyssurendran666 subyssurendran666 commented May 13, 2025

Modify existing behaviour of opening Exception Stack trace

Fix: #670

All the necessary information has been updated in the parent ticket.

What it does

How to test

Author checklist

@subyssurendran666 subyssurendran666 force-pushed the Modify_existing_behaviour_of_opening_Exception_Stack_trace_670 branch from 0f94aa8 to 990bbce Compare May 14, 2025 05:05
Comment thread org.eclipse.jdt.debug/model/org/eclipse/jdt/debug/core/JDIDebugModel.java Outdated
Modify existing behaviour of opening Exception Stack trace

Fix: eclipse-jdt#670
@subyssurendran666 subyssurendran666 force-pushed the Modify_existing_behaviour_of_opening_Exception_Stack_trace_670 branch from 0b232e4 to 9ce3653 Compare May 14, 2025 07:41
Copy link
Copy Markdown
Member

@SougandhS SougandhS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SougandhS SougandhS merged commit 3f5554e into eclipse-jdt:master May 14, 2025
13 checks passed
SougandhS added a commit that referenced this pull request May 21, 2025
* Touch bundles affected by compiler changes

See eclipse-platform/eclipse.platform.releng.aggregator#2995

* Don't use Display.syncExec() for refresh in RuntimeClasspathViewer

The listener may be called from a background thread that already holds
some locks. To refresh RuntimeClasspathViewer UI in the current case,
syncExec is not needed, asyncExec is enough and it would not acquire the
UI lock from an unknown thread.

Fixes #672

* Force qualifier update to fix build failure

eclipse-platform/eclipse.platform.releng.aggregator#3006

* [Build] Migrate to new tycho-apitools log and list maven issues

Also make sure the issues are published even in case of a failed build,
as otherwise they are not visualized and improve order of post-actions.

Additionally record maven issues, but don't add a quality-gate for them.

* Fixed Trigger point disabled automatically (#667)

The trigger point is being disabled during debugging when a conditional
breakpoint is hit.

Fixes: #546

* Regression fix in (#688)

#608

Invalid links generated with multiple spaces

Fixes : #687

* Disable on hit for Breakpoints (#682)

Disable on Hit feature is now supported for all breakpoints except
trigger points

Fixes: #680

* Add SVGs to org.eclipse.jdt.debug Bundles (#678)

* add all svgs to eclipse.jdt.debug bundles

This commit adds SVGs for all icons in the bundle `org.eclipse.jdt.debug.ui` except for the following as these are not available as SVG yet:

obj16/groupedframe.svg
obj16/javastacktrace_console.svg
obj16/jexcept_obj.svg

Referenced icons from `org.eclipse.debug.ui` were also changed to SVG as these already exist.

Please note that `JDT Debug` also has the following missing SVGs in other bundles:

org.eclipse.jdt.launching.ui.macosx/icons/full/ctool16/exportappbundle_wiz.xvg
org.eclipse.jdt.launching.ui.macosx/icons/full/wizban/exportapp_wiz.xvg
org.eclipse.jdt.debug.setup - JDTDebugConfiguration.setup  uses the following link: `https://www.eclipse.org/downloads/images/committers.png`

* Remove explicit disabled icons from org.eclipse.jdt.debug.ui

Use on-the-fly-generated disabled version of SVG-rasterized icons instead.

Hardcoded disabled entries in class `JavaDebugImages` can't be removed as other classes depend on them.  These entries use a specific disabled icon variant which also exists as SVG.

* Modify existing behaviour of opening Exception Stack trace (#698)

Add option for navigating to exception types in editor instead of directly creating or modifying exception breakpoints on clicking exception types from console

Fix: #670

* Additional handling for Disable on Hit (#699)

This commit moves disable on hit check to JDIThread class + uncheck the option when disabled

* Method Breakpoint does not recognised when set at end of a method (#700)

This PR fixes the issue where breakpoints set at method closing braces did not created exit method breakpoints

Fix: #697

---------

Co-authored-by: Andrey Loskutov <loskutov@gmx.de>
Co-authored-by: Ed Merks <ed.merks@gmail.com>
Co-authored-by: Hannes Wellmann <wellmann.hannes1@gmx.net>
Co-authored-by: Suby S Surendran <suby.surendran@ibm.com>
Co-authored-by: Michael Bangas <102024826+Michael5601@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modify existing behaviour of opening Exception Stack trace

2 participants