Skip to content

Remove now unnecessary suppression of warning about missing serial-UID#737

Merged
iloveeclipse merged 1 commit intoeclipse-jdt:masterfrom
HannesWell:remove-serial-warning-suppression
Jul 17, 2025
Merged

Remove now unnecessary suppression of warning about missing serial-UID#737
iloveeclipse merged 1 commit intoeclipse-jdt:masterfrom
HannesWell:remove-serial-warning-suppression

Conversation

@HannesWell
Copy link
Copy Markdown
Contributor

What it does

See

Author checklist

@HannesWell
Copy link
Copy Markdown
Contributor Author

@SarikaSinha, @iloveeclipse or anybody else from JDT, it would be great to have this submitted ASAP.

@iloveeclipse
Copy link
Copy Markdown
Member

I assume Jenkins check will fail on compilation? Have you checked in IDE whether bundle version needs a bump for 4.37?

@HannesWell
Copy link
Copy Markdown
Contributor Author

I assume Jenkins check will fail on compilation?

At least in the IDE it was only a warning (haven't checked if the CI is configured to be more strict). I suggest we await the result, maybe it passes (only with a quality gate issue).

Have you checked in IDE whether bundle version needs a bump for 4.37?

Yes, it was already bumped five weeks ago (and the version-check is also green).

@HannesWell
Copy link
Copy Markdown
Contributor Author

I assume Jenkins check will fail on compilation?

At least in the IDE it was only a warning (haven't checked if the CI is configured to be more strict). I suggest we await the result, maybe it passes (only with a quality gate issue).

@iloveeclipse this passed with only the anticipated quality-gate miss:
grafik

@iloveeclipse iloveeclipse merged commit 67f98cf into eclipse-jdt:master Jul 17, 2025
10 of 13 checks passed
@HannesWell HannesWell deleted the remove-serial-warning-suppression branch July 17, 2025 18:40
@HannesWell
Copy link
Copy Markdown
Contributor Author

Thank you for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants