Skip to content

Wait for specific MethodExitEvent in MethodReturnValuesTests#897

Merged
trancexpress merged 2 commits intoeclipse-jdt:masterfrom
trancexpress:gh528
Mar 8, 2026
Merged

Wait for specific MethodExitEvent in MethodReturnValuesTests#897
trancexpress merged 2 commits intoeclipse-jdt:masterfrom
trancexpress:gh528

Conversation

@trancexpress
Copy link
Copy Markdown
Contributor

MethodReturnValuesTests can receive multiple MethodExitEvent events, before calling EventWaiter.waitEvent(). As a result, the test can potentially make its checks on the wrong event, e.g. for: MainClass.triggerEvent()

This change ensures only the MethodExitEvent for the correct method is accepted by EventWaiter.

Fixes: #528

@eclipse-jdt-bot
Copy link
Copy Markdown
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

org.eclipse.jdt.debug.jdi.tests/META-INF/MANIFEST.MF
org.eclipse.jdt.debug.jdi.tests/pom.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From d6191de3481e8775536e2c0353b638999d94d14d Mon Sep 17 00:00:00 2001
From: Eclipse JDT Bot <jdt-bot@eclipse.org>
Date: Thu, 5 Mar 2026 11:05:59 +0000
Subject: [PATCH] Version bump(s) for 4.40 stream


diff --git a/org.eclipse.jdt.debug.jdi.tests/META-INF/MANIFEST.MF b/org.eclipse.jdt.debug.jdi.tests/META-INF/MANIFEST.MF
index 96f671ae0..23e60d18e 100644
--- a/org.eclipse.jdt.debug.jdi.tests/META-INF/MANIFEST.MF
+++ b/org.eclipse.jdt.debug.jdi.tests/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: JDI Tests
 Bundle-SymbolicName: org.eclipse.jdt.debug.jdi.tests; singleton:=true
-Bundle-Version: 1.2.100.qualifier
+Bundle-Version: 1.2.200.qualifier
 Bundle-ClassPath: .
 Bundle-Vendor: Eclipse
 Require-Bundle: org.junit,
diff --git a/org.eclipse.jdt.debug.jdi.tests/pom.xml b/org.eclipse.jdt.debug.jdi.tests/pom.xml
index 830677cac..dd9aae4cc 100644
--- a/org.eclipse.jdt.debug.jdi.tests/pom.xml
+++ b/org.eclipse.jdt.debug.jdi.tests/pom.xml
@@ -18,7 +18,7 @@
   </parent>
   <groupId>org.eclipse.jdt</groupId>
   <artifactId>org.eclipse.jdt.debug.jdi.tests</artifactId>
-  <version>1.2.100-SNAPSHOT</version>
+  <version>1.2.200-SNAPSHOT</version>
   <packaging>eclipse-test-plugin</packaging>
   <properties>
     <testSuite>${project.artifactId}</testSuite>
-- 
2.53.0

Further information are available in Common Build Issues - Missing version increments.

@trancexpress
Copy link
Copy Markdown
Contributor Author

@iloveeclipse how do I get access to Copilot reviews? I can't select Copilot on the reviewer list. I did opt in for Copilot enterprise from Eclipse.

trancexpress and others added 2 commits March 8, 2026 12:10
MethodReturnValuesTests can receive multiple MethodExitEvent events, before calling EventWaiter.waitEvent().
As a result, the test can potentially make its checks on the wrong event, e.g. for: MainClass.triggerEvent()

This change ensures only the MethodExitEvent for the correct method is accepted by EventWaiter.

Fixes: eclipse-jdt#528
@trancexpress trancexpress merged commit 234ac3a into eclipse-jdt:master Mar 8, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Random failed MethodReturnValuesTests.testGetBooleanMethodReturnValue

2 participants