Avoid detecting JUnit version based on restricted annotations

CoreTestSearchEngine.hasJUnit6TestAnnotation() will detect JUnit 6
if a classpath entry for junit-platform-commons 6 exists,
but has forbidden access rule restriction.

This change adjusts the search for the JUnit 5 and 6 annotation types
to also consider classpath access rules.

Fixes: #2830

Author: trancexpress

org.eclipse.jdt.junit.core/src/org/eclipse/jdt/internal/junit/util/CoreTestSearchEngine.java

@@ -52,6 +52,9 @@
 import org.eclipse.jdt.core.search.SearchPattern;
 import org.eclipse.jdt.core.search.SearchRequestor;
 
+import org.eclipse.jdt.internal.core.DefaultWorkingCopyOwner;
+import org.eclipse.jdt.internal.core.JavaProject;
+import org.eclipse.jdt.internal.core.NameLookup;
 import org.eclipse.jdt.internal.core.PackageFragmentRoot;
 import org.eclipse.jdt.internal.junit.JUnitCorePlugin;
 import org.eclipse.jdt.internal.junit.buildpath.BuildPathSupport;
@@ -169,10 +172,10 @@ private static boolean hasJUnitJupiterTestAnnotation(IJavaProject project, int j
 		try {
 			if (project != null) {
 				String junitBundlePrefix = JUNIT_PLATFORM_COMMONS_PREFIX;
-				IType type= project.findType(JUnitCorePlugin.JUNIT5_TESTABLE_ANNOTATION_NAME);
+				IType type= findAnnotation(project, JUnitCorePlugin.JUNIT5_TESTABLE_ANNOTATION_NAME);
 				if (type == null) {
 					junitBundlePrefix = JUNIT_PLATFORM_SUITE_API_PREFIX;
-					type= project.findType(JUnitCorePlugin.JUNIT5_SUITE_ANNOTATION_NAME);
+					type= findAnnotation(project, JUnitCorePlugin.JUNIT5_SUITE_ANNOTATION_NAME);
 				}
 				if (type != null) {
 					// check if we have the right JUnit JUpiter version
@@ -331,4 +334,22 @@ public static void findSuiteMethods(IJavaElement element, Set<IType> result, IPr
 		SearchParticipant[] participants= new SearchParticipant[] { SearchEngine.getDefaultSearchParticipant() };
 		new SearchEngine().search(suitePattern, participants, scope, requestor, pm);
 	}
+
+	private static IType findAnnotation(IJavaProject project, String fullyQualifiedName) throws JavaModelException {
+		if (project instanceof JavaProject p) {
+			NameLookup lookup= p.newNameLookup(DefaultWorkingCopyOwner.PRIMARY);
+			NameLookup.Answer answer = lookup.findType(
+					fullyQualifiedName,
+					false /* no partial matches */,
+					NameLookup.ACCEPT_ANNOTATIONS,
+					false /* no secondary types */,
+					true /* wait for indexer */,
+					true /* check restrictions */,
+					null);
+			if (answer != null) {
+				return answer.type;
+			}
+		}
+		return null;
+	}
 }