Remove obsolete ICU references from surrogate-handling comments (#2977)

The XXX comments referenced com.ibm.icu.lang.UCharacter and
java.lang.Character behavior on Java 1.4. ICU is no longer a
dependency, and the surrogate branches contained no actual logic, so
fold the surrogate check into the outer condition and drop the stale
comments.

Author: vogella

org.eclipse.jdt.junit/src/org/eclipse/jdt/junit/wizards/NewTestCaseWizardPageOne.java

@@ -1107,19 +1107,8 @@ else if (character == '<')
 				buffer.replace(index, index + 1, OF_TAG);
 			else if (character == '?')
 				buffer.replace(index, index + 1, QUESTION_MARK_TAG);
-			else if (!Character.isJavaIdentifierPart(character)) {
-				// Check for surrogates
-				if (!Character.isSurrogate(character)) {
-					/*
-					 * XXX: Here we should create the code point and test whether
-					 * it is a Java identifier part. Currently this is not possible
-					 * because java.lang.Character in 1.4 does not support surrogates
-					 * and because com.ibm.icu.lang.UCharacter.isJavaIdentifierPart(int)
-					 * is not correctly implemented.
-					 */
-					buffer.deleteCharAt(index);
-				}
-
+			else if (!Character.isJavaIdentifierPart(character) && !Character.isSurrogate(character)) {
+				buffer.deleteCharAt(index);
 			}
 		}
 	}

org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/JavaWordFinder.java

@@ -32,19 +32,8 @@ public static IRegion findWord(IDocument document, int offset) {
 
 			while (pos >= 0) {
 				c= document.getChar(pos);
-				if (!Character.isJavaIdentifierPart(c)) {
-					// Check for surrogates
-					if (Character.isSurrogate(c)) {
-						/*
-						 * XXX: Here we should create the code point and test whether
-						 * it is a Java identifier part. Currently this is not possible
-						 * because java.lang.Character in 1.4 does not support surrogates
-						 * and because com.ibm.icu.lang.UCharacter.isJavaIdentifierPart(int)
-						 * is not correctly implemented.
-						 */
-					} else {
-						break;
-					}
+				if (!Character.isJavaIdentifierPart(c) && !Character.isSurrogate(c)) {
+					break;
 				}
 				--pos;
 			}
@@ -55,19 +44,8 @@ public static IRegion findWord(IDocument document, int offset) {
 
 			while (pos < length) {
 				c= document.getChar(pos);
-				if (!Character.isJavaIdentifierPart(c)) {
-					if (Character.isSurrogate(c)) {
-						/*
-						 * XXX: Here we should create the code point and test whether
-						 * it is a Java identifier part. Currently this is not possible
-						 * because java.lang.Character in 1.4 does not support surrogates
-						 * and because com.ibm.icu.lang.UCharacter.isJavaIdentifierPart(int)
-						 * is not correctly implemented.
-						 */
-					} else {
-						break;
-					}
-
+				if (!Character.isJavaIdentifierPart(c) && !Character.isSurrogate(c)) {
+					break;
 				}
 				++pos;
 			}