Use ProjectionRegion in folding tests#3073
Merged
iloveeclipse merged 1 commit intoJul 20, 2026
Merged
Conversation
fedejeanne
changed the title
fedejeanne
force-pushed
the
codex/folding-projection-region-utils
branch
from
July 14, 2026 06:25
e143c61 to
6187236
Compare
fedejeanne
marked this pull request as ready for review
July 14, 2026 06:26
Contributor
Author
|
@iloveeclipse this PR is a follow-up of #3052 and it only changes test classes in order to make them more amicable to the programmer. Would you kindly review and merge? :-) |
iloveeclipse
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of (and also contains):
I am drafting this PR until #3052 is merged so that the reviewer can focus on the changes of the 2nd commit only.
What it does
Replaces all usages of
IRegioninFoldingTestUtilsfor usages ofProjectionRegion(internal record). This makes the API of the utility class easier to use and avoids functionality duplication.ProjectionRegionnot only contains the length and offset of a region but also its state: collapsed/expanded.How to test
Run the tests in
org.eclipse.jdt.text.tests.folding.FoldingTestSuite, they should pass.Author checklist