Replace usages of new Image(device, width, height)

[ShahzaibIbrahim]

Replacing it with imageGcDrawer constructor Image(device, imageGcDrawer, width, height). Later Image(device, width, height) is set to be deprecated.

Requires

• Add getGcStyle() method to accommodate styling eclipse-platform/eclipse.platform.swt#1948

Author checklist

• [ x ] I have thoroughly tested my changes
• [ x ] The change is following the coding conventions
• [ x ] I have signed the Eclipse Contributor Agreement (ECA)

[fedejeanne]

I tested by:

• Activating the breadcrumb for Java
• Renaming a method

I wasn't able to test the change in SignatureStylingColorPreferenceMenuItem though, I have no styling enhancements installed.

Nevertheless, the change in the code looks good.

LGTM, thank you! ✔️

Now we need the approval of a committer (@iloveeclipse / @jjohnstn ?)

[fedejeanne]

I just rebased on master. The compilation error should go away.

[fedejeanne]

I just rebased on master again.

@jjohnstn / @iloveeclipse would you kindly review and merge?

[jjohnstn]

Looks good. We have an issue with Jenkins at the moment so there will be a delay in merging.

[fedejeanne]

@jjohnstn the check failure is because Tycho 4.0.13-SNAPSHOT is picked up from the EF infrastructure and therefore currently not available.

Error:  Plugin org.eclipse.tycho:tycho-versions-plugin:4.0.13-SNAPSHOT or one of its dependencies could not be resolved:
Error:   The following artifacts could not be resolved: org.eclipse.tycho:tycho-versions-plugin:pom:4.0.13-SNAPSHOT (absent): org.eclipse.tycho:tycho-versions-plugin:pom:4.0.13-SNAPSHOT failed to transfer from https://repo.eclipse.org/content/repositories/tycho-snapshots/ during a previous attempt. This failure was cached in the local repository and resolution is not reattempted until the update interval of tycho-snapshots has elapsed or updates are forced. Original error: Could not transfer artifact org.eclipse.tycho:tycho-versions-plugin:pom:4.0.13-SNAPSHOT from/to tycho-snapshots (https://repo.eclipse.org/content/repositories/tycho-snapshots/): status code: 403, reason phrase: Forbidden (403)

This workaround was added 1 day after the check failure and it lets the check use Tycho 4.0.12, which is picked up from maven central.

Long story short: can you please re-trigger the check and see if the 403 error goes away?

[fedejeanne]

Long story short: can you please re-trigger the check and see if the 403 error goes away?

Oh, I have write permissions in vi-eclipse, I forgot. I rebased, which will trigger the checks.