Skip to content

Add SVGs to org.eclipse.jdt.jeview#2173

Merged
jjohnstn merged 2 commits intoeclipse-jdt:masterfrom
Michael5601:org.eclipse.jdt.jeview.SVGs
Apr 28, 2025
Merged

Add SVGs to org.eclipse.jdt.jeview#2173
jjohnstn merged 2 commits intoeclipse-jdt:masterfrom
Michael5601:org.eclipse.jdt.jeview.SVGs

Conversation

@Michael5601
Copy link
Copy Markdown
Contributor

This PR adds SVGs for all icons in the bundle org.eclipse.jdt.jeview.

See also this PR for more information.

@eclipse-jdt-bot
Copy link
Copy Markdown
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

org.eclipse.jdt.jeview.feature/feature.xml
org.eclipse.jdt.jeview/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From b1359c4efb8d8ee3dc0a9a54c4a46947b1cc1f34 Mon Sep 17 00:00:00 2001
From: Eclipse JDT Bot <jdt-bot@eclipse.org>
Date: Tue, 22 Apr 2025 15:58:13 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/org.eclipse.jdt.jeview.feature/feature.xml b/org.eclipse.jdt.jeview.feature/feature.xml
index b673e5ba1d..09cbfb2d28 100644
--- a/org.eclipse.jdt.jeview.feature/feature.xml
+++ b/org.eclipse.jdt.jeview.feature/feature.xml
@@ -2,7 +2,7 @@
 <feature
       id="org.eclipse.jdt.jeview.feature"
       label="Java Element View"
-      version="1.1.600.qualifier"
+      version="1.1.700.qualifier"
       provider-name="Eclipse.org"
       license-feature="org.eclipse.license"
       license-feature-version="0.0.0">
diff --git a/org.eclipse.jdt.jeview/META-INF/MANIFEST.MF b/org.eclipse.jdt.jeview/META-INF/MANIFEST.MF
index 1d62eeab09..e43d5c63fe 100644
--- a/org.eclipse.jdt.jeview/META-INF/MANIFEST.MF
+++ b/org.eclipse.jdt.jeview/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Automatic-Module-Name: org.eclipse.jdt.jeview
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.jdt.jeview; singleton:=true
-Bundle-Version: 1.6.0.qualifier
+Bundle-Version: 1.6.100.qualifier
 Bundle-Activator: org.eclipse.jdt.jeview.JEViewPlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

Copy link
Copy Markdown
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is sound.

It adopts the support for SVGs added to SWT in order to provide sharp icons for any, even fractional zoom from a single source: eclipse-platform/eclipse.platform.swt#1638

Disabled icons are not replaced by SVGs but are to be replaced with on-the-fly generation from the enabled version, see:

Michael5601 and others added 2 commits April 28, 2025 17:30
This commit adds SVGs for all icons in the bundle `eclipse.jdt.jeview`.
@jjohnstn jjohnstn merged commit 2018130 into eclipse-jdt:master Apr 28, 2025
6 checks passed
@jjohnstn jjohnstn self-assigned this Apr 28, 2025
@jjohnstn jjohnstn added this to the 4.36 M2 milestone Apr 28, 2025
@Michael5601 Michael5601 deleted the org.eclipse.jdt.jeview.SVGs branch April 29, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants