Add SVGs to org.eclipse.jdt.ui bundles#2174
Merged
jjohnstn merged 1 commit intoeclipse-jdt:masterfrom Apr 28, 2025
Michael5601:org.eclipse.jdt.ui.SVGs
Merged
Add SVGs to org.eclipse.jdt.ui bundles#2174jjohnstn merged 1 commit intoeclipse-jdt:masterfrom Michael5601:org.eclipse.jdt.ui.SVGs
jjohnstn merged 1 commit intoeclipse-jdt:masterfrom
Michael5601:org.eclipse.jdt.ui.SVGs
Conversation
This commit adds SVGs for all icons in the bundles `eclipse.jdt.ui` and `eclipse.jdt.ui.unittest.junit` except for the following as these do not yet exist as SVG: eclipse.jdt.ui/etool16/move_up.svg eclipse.jdt.ui/wizban/newrecord_wiz.svg Not all icons can be loaded via SVGs since some icons are made API via org.eclipse.jdt.ui.ISharedImages. There is a converter that was used for loading PNGs instead. I adjusted this converter so SVGs will be loaded: `org.eclipse.jdt.internal.ui.JavaPluginImages.createImageDescriptor(Bundle, IPath, boolean)` I did not change the functionality in `org.eclipse.jdt.internal.ui.viewsupport.ImagesOnFileSystemRegistry.getNewFile()` by changing `.png` to `.svg` as I don't know the side effects.
3 tasks
HeikoKlare
approved these changes
Apr 28, 2025
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
The change is sound.
It adopts the support for SVGs added to SWT in order to provide sharp icons for any, even fractional zoom from a single source: eclipse-platform/eclipse.platform.swt#1638
Disabled icons are not replaced by SVGs but are to be replaced with on-the-fly generation from the enabled version, see:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds SVGs for all icons in the bundles
eclipse.jdt.uiandeclipse.jdt.ui.unittest.junitexcept for the following as these do not yet exist as SVG:eclipse.jdt.ui/etool16/move_up.svg
eclipse.jdt.ui/wizban/newrecord_wiz.svg
Not all icons can be loaded via SVGs since some icons are made API via
org.eclipse.jdt.ui.ISharedImages. There is a converter that was used for loading PNGs instead. I adjusted this converter so SVGs will be loaded:org.eclipse.jdt.internal.ui.JavaPluginImages.createImageDescriptor(Bundle, IPath, boolean)I did not change the functionality in
org.eclipse.jdt.internal.ui.viewsupport.ImagesOnFileSystemRegistry.getNewFile()by changing.pngto.svgas I don't know the side effects.Icon disablement is not yet removed.
See also this PR for more information.