Add SVGs to org.eclipse.jdt.junit#2179
Add SVGs to org.eclipse.jdt.junit#2179jjohnstn merged 2 commits intoeclipse-jdt:masterfrom Michael5601:org.eclipse.jdt.junit.SVGs
Conversation
This commit adds SVGs for all icons in the bundles `org.eclipse.jdt.junit`. For some icons the icon path is constructed in the following method by adding icon disablement information. Changing these paths works fine: `org.eclipse.jdt.internal.junit.ui.JUnitPlugin.setImageDescriptors(IAction, String, String)` The affected icons are found in the class `TestRunnerViewPart`: - `history_list.png` - `stop.png` - `relaunch.png` - `relaunchf.png`
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
HeikoKlare
left a comment
There was a problem hiding this comment.
The change is sound.
It adopts the support for SVGs added to SWT in order to provide sharp icons for any, even fractional zoom from a single source: eclipse-platform/eclipse.platform.swt#1638
Disabled icons are not replaced by SVGs but are to be replaced with on-the-fly generation from the enabled version, see:
The unnecessary specification of hover images, which is also affected by this PR, is removed with:
This commit adds SVGs for all icons in the bundle
org.eclipse.jdt.junit.For some icons the icon path is constructed in the following method by adding icon disablement information. Changing these paths works fine:
org.eclipse.jdt.internal.junit.ui.JUnitPlugin.setImageDescriptors(IAction, String, String)The affected icons are found in the class
TestRunnerViewPart:history_list.pngstop.pngrelaunch.pngrelaunchf.pngPlease also note that the icon
time_obj.svgfrom the images repository had a massive amount of linear gradients that were not visible but lead to JSVG crashing. I fixed the icon and reduced the icon size by factor 70 in this PR in the images repository.I added the fixed icon in this PR and now it works fine.