Skip to content

Add new quick-fix/clean-up to replace deprecated fields if possible#2254

Merged
jjohnstn merged 2 commits into
eclipse-jdt:masterfrom
jjohnstn:deprecatedfields
Jun 16, 2025
Merged

Add new quick-fix/clean-up to replace deprecated fields if possible#2254
jjohnstn merged 2 commits into
eclipse-jdt:masterfrom
jjohnstn:deprecatedfields

Conversation

@jjohnstn

@jjohnstn jjohnstn commented Jun 4, 2025

Copy link
Copy Markdown
Contributor
  • add new ReplaceDeprecatedFieldCleanUpCore and ReplaceDeprecatedFieldFixCore classes
  • add new method QuickAssistProcessorUtil.getDeprecatedFieldReplacement
  • add new logic to QuickFixProcessor and QuickAssistProcessor
  • add new option to SourceFixingTabPage to perform replace fields clean-up
  • add new tests to CleanUpTest1d8
  • fixes Add new quick-assist/cleanup for replacing deprecated fields #2242

What it does

See issue.

How to test

See issue or new tests.

Author checklist

@jjohnstn jjohnstn self-assigned this Jun 4, 2025
@jjohnstn jjohnstn added enhancement New feature or request noteworthy Noteworthy feature labels Jun 4, 2025
@jjohnstn jjohnstn added this to the 4.37 M1 milestone Jun 4, 2025
@eclipse-jdt-bot

Copy link
Copy Markdown
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

org.eclipse.jdt.core.manipulation/META-INF/MANIFEST.MF
org.eclipse.jdt.ui.tests/META-INF/MANIFEST.MF
org.eclipse.jdt.ui.tests/pom.xml
org.eclipse.jdt.ui/META-INF/MANIFEST.MF
org.eclipse.jdt.ui/pom.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 0d218b4ab985e1da7ad4a69624f7ca34f468c9e1 Mon Sep 17 00:00:00 2001
From: Eclipse JDT Bot <jdt-bot@eclipse.org>
Date: Wed, 4 Jun 2025 19:04:06 +0000
Subject: [PATCH] Version bump(s) for 4.37 stream


diff --git a/org.eclipse.jdt.core.manipulation/META-INF/MANIFEST.MF b/org.eclipse.jdt.core.manipulation/META-INF/MANIFEST.MF
index 37d5bfd872..0e1d1c4783 100644
--- a/org.eclipse.jdt.core.manipulation/META-INF/MANIFEST.MF
+++ b/org.eclipse.jdt.core.manipulation/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Automatic-Module-Name: org.eclipse.jdt.core.manipulation
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.jdt.core.manipulation; singleton:=true
-Bundle-Version: 1.23.0.qualifier
+Bundle-Version: 1.23.100.qualifier
 Bundle-Vendor: %providerName
 Bundle-Activator: org.eclipse.jdt.internal.core.manipulation.JavaManipulationPlugin
 Bundle-Localization: plugin
diff --git a/org.eclipse.jdt.ui.tests/META-INF/MANIFEST.MF b/org.eclipse.jdt.ui.tests/META-INF/MANIFEST.MF
index cdbc0d658b..150de53e6e 100644
--- a/org.eclipse.jdt.ui.tests/META-INF/MANIFEST.MF
+++ b/org.eclipse.jdt.ui.tests/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Automatic-Module-Name: org.eclipse.jdt.ui.tests
 Bundle-ManifestVersion: 2
 Bundle-Name: %Plugin.name
 Bundle-SymbolicName: org.eclipse.jdt.ui.tests; singleton:=true
-Bundle-Version: 3.16.100.qualifier
+Bundle-Version: 3.16.200.qualifier
 Bundle-Activator: org.eclipse.jdt.testplugin.JavaTestPlugin
 Bundle-Vendor: %Plugin.providerName
 Bundle-Localization: plugin
diff --git a/org.eclipse.jdt.ui.tests/pom.xml b/org.eclipse.jdt.ui.tests/pom.xml
index 6c1935b1d3..e9ebf4d752 100644
--- a/org.eclipse.jdt.ui.tests/pom.xml
+++ b/org.eclipse.jdt.ui.tests/pom.xml
@@ -20,7 +20,7 @@
   </parent>
   <groupId>org.eclipse.jdt</groupId>
   <artifactId>org.eclipse.jdt.ui.tests</artifactId>
-  <version>3.16.100-SNAPSHOT</version>
+  <version>3.16.200-SNAPSHOT</version>
   <packaging>eclipse-test-plugin</packaging>
   <properties>
     <defaultSigning-excludeInnerJars>true</defaultSigning-excludeInnerJars>
diff --git a/org.eclipse.jdt.ui/META-INF/MANIFEST.MF b/org.eclipse.jdt.ui/META-INF/MANIFEST.MF
index f6b27006e0..a069d32d53 100644
--- a/org.eclipse.jdt.ui/META-INF/MANIFEST.MF
+++ b/org.eclipse.jdt.ui/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Automatic-Module-Name: org.eclipse.jdt.ui
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.jdt.ui; singleton:=true
-Bundle-Version: 3.35.0.qualifier
+Bundle-Version: 3.35.100.qualifier
 Bundle-Activator: org.eclipse.jdt.internal.ui.JavaPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %providerName
diff --git a/org.eclipse.jdt.ui/pom.xml b/org.eclipse.jdt.ui/pom.xml
index 02500042e3..c91c75bcfc 100644
--- a/org.eclipse.jdt.ui/pom.xml
+++ b/org.eclipse.jdt.ui/pom.xml
@@ -18,7 +18,7 @@
   </parent>
   <groupId>org.eclipse.jdt</groupId>
   <artifactId>org.eclipse.jdt.ui</artifactId>
-  <version>3.35.0-SNAPSHOT</version>
+  <version>3.35.100-SNAPSHOT</version>
   <packaging>eclipse-plugin</packaging>
 
 	<build>
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

@jjohnstn
jjohnstn force-pushed the deprecatedfields branch from cd83a9f to 95005d1 Compare June 9, 2025 13:54
jjohnstn added 2 commits June 16, 2025 15:05
- add new ReplaceDeprecatedFieldCleanUpCore and
  ReplaceDeprecatedFieldFixCore classes
- add new method QuickAssistProcessorUtil.getDeprecatedFieldReplacement
- add new logic to QuickFixProcessor and QuickAssistProcessor
- add new option to SourceFixingTabPage to perform replace fields
  clean-up
- add new tests to CleanUpTest1d8
- fixes eclipse-jdt#2242
@jjohnstn
jjohnstn merged commit 905eb1c into eclipse-jdt:master Jun 16, 2025
13 checks passed
@jjohnstn
jjohnstn deleted the deprecatedfields branch June 16, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request noteworthy Noteworthy feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new quick-assist/cleanup for replacing deprecated fields

2 participants