Skip to content

Do not return null from ClassFileEditorInputFactory when type not found #2372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
laeubi wants to merge 1 commit into from
Closed

Do not return null from ClassFileEditorInputFactory when type not found #2372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditorInputFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public IAdaptable createElement(IMemento memento) {
if (project != null) {
type= project.findType(type.getFullyQualifiedName());
if (type == null)
return null;
return new InternalClassFileEditorInput(cf);
Copy link
Copy Markdown
Member

@iloveeclipse iloveeclipse Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've commented already on #2353 (comment).

This would bring back the problem described in the comment above, see https://bugs.eclipse.org/bugs/show_bug.cgi?id=83221

I will push a patch that fixes that in a different way without regression.

Copy link
Copy Markdown
Contributor Author

@laeubi laeubi Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would bring back the problem described in the comment above, see https://bugs.eclipse.org/bugs/show_bug.cgi?id=83221

Can you please explain why. The null is only returned when the type is not found, the Bug 83221 is fixing the case where it is found...

Copy link
Copy Markdown
Member

@iloveeclipse iloveeclipse Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of #2245 aka eclipse-pde/eclipse.pde#1667.

Copy link
Copy Markdown
Contributor Author

@laeubi laeubi Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of #2245 aka eclipse-pde/eclipse.pde#1667.

Have you tried out the reproducer? It does not contain anything from PDE just plain JDT project...

Copy link
Copy Markdown
Contributor Author

@laeubi laeubi Jul 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please look at the patch from Bug 83221 da65fe2

it does not aimed to ever return null .. then there was a potential problem that the type is null and the check was returned then returning null here 5a30402 .

so how could it be a "regression" to the bug if it never would open the editor in such case? This does not make sense as one really can't depend on seeing a broken ClassFileEditor (again without PDE) after a restart, so this is clearly a bug and it is unrelated to if PDE has any change or not.

You asked me to stay "professional" but honestly this does not feel any profession from your side to ever repeat the same sentence without even look at the reported problem.

Copy link
Copy Markdown
Member

@iloveeclipse iloveeclipse Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but honestly this does not feel any profession from your side to ever repeat the same sentence without even look at the reported problem.

How do you know that? Please stop making offending personal comments!
Please carefully read https://github.com/eclipse-jdt/eclipse.jdt.ui?tab=coc-ov-file#our-standards and understand that personal attacks are violating our code of conduct.

I do not want to answer to such comments anymore.

Copy link
Copy Markdown
Contributor Author

@laeubi laeubi Jul 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You asked me to create an own issue for my different problem and I did it here:

it describes detailed steps how to reproduce the issue that ClassFileEditorInputFactory return null with an example project that only uses JDT.

I also added detailed description in the PR to fix that problem when it was introduced and why it causes problem.

Then you argue that it is caused by a change in PDE... so maybe you can kindly give me an advice on what conclusion I should draw from that?

element= type.getParent();
}
}
Expand Down
Loading