Add import module support to organize imports#2431
Open
jjohnstn wants to merge 2 commits intoeclipse-jdt:masterfrom
Open
Add import module support to organize imports#2431jjohnstn wants to merge 2 commits intoeclipse-jdt:masterfrom
jjohnstn wants to merge 2 commits intoeclipse-jdt:masterfrom
Conversation
Contributor
Author
|
This PR requires eclipse-jdt/eclipse.jdt.core#4309 |
Contributor
Author
|
@iloveeclipse Any chance you could look at this plus eclipse-jdt/eclipse.jdt.core#4309? The core change cited is required for this to work. I couldn't get a test working for just ImportRewrite because while it works fine in my new JDT UI test which sets up a Java24 project, the ImportRewrite tests use a different set up and it keeps failing for me because inner methods trying to create an AST can't find java.lang.Object, etc... and thus there are no bindings created. I'm sure I could figure it out in the future, but with M3 coming fast, I thought it would be good to have initial import module support for the 2025-09 release. |
Member
|
Sorry, I'm out of PC till the end of month. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
In conjunction with changes to ImportRewrite, fixes organize imports when import module is used.
How to test
See new test or original issue.
Author checklist