Migrate from SubProgressMonitor to SubMonitor#2641
Open
vogella wants to merge 1 commit into
Open
Conversation
25f7c6c to
5161d45
Compare
5161d45 to
7906c72
Compare
7906c72 to
c0af4de
Compare
c0af4de to
6846852
Compare
Contributor
Author
|
I will split the changes in org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/wizards/NewTypeWizardPage.java out of this |
6846852 to
eb8e014
Compare
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
This commit migrates the editor save code from the deprecated SubProgressMonitor (deprecated since Eclipse 4.6 Neon) to SubMonitor as per Eclipse API recommendations. Changes: - Migrated EditorUtility.java to use the SubMonitor pattern directly, removing the getSubProgressMonitor method and unused imports - Migrated CompilationUnitDocumentProvider.java to use the SubMonitor pattern in commitWorkingCopy and notifyPostSaveListeners methods - Removed calls to monitor.done() and subMonitor.done() where not needed (SubMonitor handles cleanup automatically in most cases) The migration follows the official Eclipse migration guide: - Replaced IProgressMonitor.beginTask() with SubMonitor.convert() - Replaced new SubProgressMonitor(monitor, ticks) with split(ticks)
4d443df to
12ac02d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit migrates the codebase from the deprecated SubProgressMonitor (deprecated since Eclipse 4.6 Neon) to SubMonitor as per Eclipse API recommendations.
Changes:
The migration follows the official Eclipse migration guide:
What it does
How to test
Author checklist