Add semantic highlighting to the Java compare/merge viewer #2929#2930
Add semantic highlighting to the Java compare/merge viewer #2929#2930iloveeclipse merged 1 commit intoeclipse-jdt:masterfrom
Conversation
|
Build is failing because of Eclips.org infrastructure issues. |
There was a problem hiding this comment.
Pull request overview
Adds semantic highlighting support to the Java compare/merge viewer so it can render Java code with the same richer coloring as the regular Java editor (when enabled via preferences), addressing #2929.
Changes:
- Import semantic-highlighting support (
SemanticHighlightings) into the compare viewer’s editor adapter. - Install semantic highlighting in
CompilationUnitEditorAdapter.doSetInput()when semantic highlighting is enabled and a Java element is available.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Good. I was already wondering 😄 |
|
@iloveeclipse updated the PR. I would propose to integrate this which works for the Egit Revison side and create another PR for the Local History side. |
|
mea culpa, I should not just accept github suggestions 😄 |
|
You seem now use different email in the commits, so ECA is failing. Please
|
3ff833d to
1d352bd
Compare
|
@Philipp0205 : you should set commit author to the mail you've set in your Eclipse.org account. ECA check works by matching mail set there to the commit author mail. |
|
You answer faster than I can correct my mistakes 😉 |


This change installs semantic highlighting in
CompilationUnitEditorAdapter.doSetInput()when the user preference is enabled to have the same syntax higlighting in the compare viewer than in the regular java editor.Fixes #2929
Compare view before:

Compare view after:
