Skip to content

Adjust test expectation after eclipse.jdt.core/pull/5054#2981

Merged
stephan-herrmann merged 1 commit into
eclipse-jdt:masterfrom
stephan-herrmann:testFix
May 13, 2026
Merged

Adjust test expectation after eclipse.jdt.core/pull/5054#2981
stephan-herrmann merged 1 commit into
eclipse-jdt:masterfrom
stephan-herrmann:testFix

Conversation

@stephan-herrmann
Copy link
Copy Markdown
Contributor

Since eclipse-jdt/eclipse.jdt.core#5054 ECJ avoids ? extends Object, which requires the expectation of org.eclipse.jdt.ui.tests.refactoring.InferTypeArgumentsTests.testCuGetClass2() to be adjusted.

@stephan-herrmann stephan-herrmann added the test junit test related things label May 12, 2026
@stephan-herrmann stephan-herrmann added this to the 4.40 M3 milestone May 12, 2026
@stephan-herrmann
Copy link
Copy Markdown
Contributor Author

I was surprised to see that the "infer type arguments" refactoring ignores an unbound ?, but it does so independently of recent changes, so it looks OK to expect no type arguments added, when the provided type is Class<?> and the local var declared as Class.

@stephan-herrmann
Copy link
Copy Markdown
Contributor Author

@iloveeclipse iloveeclipse linked an issue May 13, 2026 that may be closed by this pull request
@stephan-herrmann stephan-herrmann merged commit 3832722 into eclipse-jdt:master May 13, 2026
13 checks passed
@stephan-herrmann stephan-herrmann deleted the testFix branch May 13, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test junit test related things

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InferTypeArgumentsTests.testCuGetClass2() fails in I-build

1 participant