Migrate code generation operations to SubMonitor#3033
Closed
vogella wants to merge 1 commit into
Closed
Conversation
Replace the raw IProgressMonitor beginTask/done lifecycle and the Progress.subMonitor helper with SubMonitor.convert and split in four code generation operations: AddDelegateMethodsOperation, AddUnimplementedConstructorsOperation, GenerateHashCodeEqualsOperation and GenerateToStringOperation. SubMonitor.convert handles null monitors and cleanup, so the explicit null guards and done() calls are no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the raw
IProgressMonitorbegin/done lifecycle and theProgress.subMonitorhelper withSubMonitor.convertandsplitin four code generation operations:AddDelegateMethodsOperation,AddUnimplementedConstructorsOperation,GenerateHashCodeEqualsOperationandGenerateToStringOperation.SubMonitor.converthandles null monitors and cleanup, so the explicit null guards anddone()calls are no longer needed. This follows the canonical pattern from the Eclipse Progress Monitors article and continues the SubProgressMonitor/SubMonitor cleanup.Builds cleanly and the dedicated source-action test suites (GenerateHashCodeEquals, AddUnimplementedConstructors, GenerateDelegateMethods, GenerateToString; 114 tests) pass.