Fix add missing method declaration when target is another CU#3076
Merged
Conversation
- modify AddMissingMethodDeclarationFixCore to properly find the type of the ExpressionMethodReference instead of looking for an ancestor of the node - verify that the method binding doesn't already exist - use the target compilation unit rather than the compilation unit where the assist is started - modify QuickAssistProcessor.getAddMethodDeclaration() to create a special FixCorrectionProposal which specifies the target CU rather than the one in the assist context - add new test to AssistQuickFixTest1d8 - fixes eclipse-jdt#3061
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
See issue.
How to test
See issue or new test.
Author checklist