Skip to content

Commit 86c88a2

Browse files
robstrykerclaude
andcommitted
Disable javac build stage to break circular dependency
Temporarily commenting out the "Fetch and tests Javac-based JDT" stage to break the circular dependency between jdt.core and jdt.javac builds. Issue: jdt.javac needs artifacts from successful jdt.core build, but if javac stage fails, the whole jdt.core build fails, preventing artifact publication. Solution: Let jdt.core build and publish artifacts successfully, then jdt.javac can build separately. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
1 parent 59a2829 commit 86c88a2

1 file changed

Lines changed: 33 additions & 31 deletions

File tree

Jenkinsfile

Lines changed: 33 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -70,36 +70,38 @@ pipeline {
7070
}
7171
}
7272
}
73-
stage('Fetch and tests Javac-based JDT') {
74-
steps {
75-
dir('eclipse.jdt.javac') {
76-
checkout scmGit(
77-
branches: [[name: 'main']],
78-
extensions: [ cloneOption(shallow: true) ],
79-
userRemoteConfigs: [[url: 'https://github.com/eclipse-jdtls/eclipse.jdt.javac.git']])
80-
sh """#!/bin/bash -x
81-
mkdir -p $WORKSPACE/tmp
82-
83-
unset JAVA_TOOL_OPTIONS
84-
unset _JAVA_OPTIONS
85-
# force qualifier to start with `z` so we identify it more easily and it always seem more recent than upstrea
86-
mvn verify --batch-mode -Djava.io.tmpdir=$WORKSPACE/tmp -Dmaven.repo.local=$WORKSPACE/.m2/repository \
87-
-Dtycho.buildqualifier.format="'z'yyyyMMdd-HHmm" \
88-
-Djava.io.tmpdir=$WORKSPACE/tmp -Dproject.build.sourceEncoding=UTF-8 \
89-
--fail-at-end -Ptest-on-javase-25 -Pbree-libs -DfailIfNoTests=false -DexcludedGroups=org.junit.Ignore -DproviderHint=junit47 \
90-
-Dmaven.test.failure.ignore=true -Dmaven.test.error.ignore=true \
91-
-pl !org.eclipse.jdt.core.tests.javac.ui
92-
"""
93-
}
94-
}
95-
post {
96-
always {
97-
archiveArtifacts artifacts: '*.log,eclipse.jdt.javac/*/target/work/data/.metadata/*.log,*/tests/target/work/data/.metadata/*.log,apiAnalyzer-workspace/.metadata/*.log,repository/target/repository/**,**/target/artifactcomparison/**', allowEmptyArchive: true
98-
junit 'eclipse.jdt.javac/org.eclipse.jdt.core.tests.javac/target/surefire-reports/*.xml'
99-
discoverGitReferenceBuild referenceJob: 'jdt-core-incubator/dom-with-javac'
100-
//recordIssues ignoreQualityGate:true, tool: junitParser(pattern: 'org.eclipse.jdt.core.tests.javac/target/surefire-reports/*.xml'), qualityGates: [[threshold: 1, type: 'DELTA', unstable: true]]
101-
}
102-
}
103-
}
73+
// Temporarily disabled to break circular dependency:
74+
// jdt.core builds tests -> publishes artifacts -> jdt.javac can build
75+
// stage('Fetch and tests Javac-based JDT') {
76+
// steps {
77+
// dir('eclipse.jdt.javac') {
78+
// checkout scmGit(
79+
// branches: [[name: 'main']],
80+
// extensions: [ cloneOption(shallow: true) ],
81+
// userRemoteConfigs: [[url: 'https://github.com/eclipse-jdtls/eclipse.jdt.javac.git']])
82+
// sh """#!/bin/bash -x
83+
// mkdir -p $WORKSPACE/tmp
84+
//
85+
// unset JAVA_TOOL_OPTIONS
86+
// unset _JAVA_OPTIONS
87+
// # force qualifier to start with `z` so we identify it more easily and it always seem more recent than upstrea
88+
// mvn verify --batch-mode -Djava.io.tmpdir=$WORKSPACE/tmp -Dmaven.repo.local=$WORKSPACE/.m2/repository \
89+
// -Dtycho.buildqualifier.format="'z'yyyyMMdd-HHmm" \
90+
// -Djava.io.tmpdir=$WORKSPACE/tmp -Dproject.build.sourceEncoding=UTF-8 \
91+
// --fail-at-end -Ptest-on-javase-25 -Pbree-libs -DfailIfNoTests=false -DexcludedGroups=org.junit.Ignore -DproviderHint=junit47 \
92+
// -Dmaven.test.failure.ignore=true -Dmaven.test.error.ignore=true \
93+
// -pl !org.eclipse.jdt.core.tests.javac.ui
94+
// """
95+
// }
96+
// }
97+
// post {
98+
// always {
99+
// archiveArtifacts artifacts: '*.log,eclipse.jdt.javac/*/target/work/data/.metadata/*.log,*/tests/target/work/data/.metadata/*.log,apiAnalyzer-workspace/.metadata/*.log,repository/target/repository/**,**/target/artifactcomparison/**', allowEmptyArchive: true
100+
// junit 'eclipse.jdt.javac/org.eclipse.jdt.core.tests.javac/target/surefire-reports/*.xml'
101+
// discoverGitReferenceBuild referenceJob: 'jdt-core-incubator/dom-with-javac'
102+
// //recordIssues ignoreQualityGate:true, tool: junitParser(pattern: 'org.eclipse.jdt.core.tests.javac/target/surefire-reports/*.xml'), qualityGates: [[threshold: 1, type: 'DELTA', unstable: true]]
103+
// }
104+
// }
105+
// }
104106
}
105107
}

0 commit comments

Comments
 (0)