Fix some qualified type relevances by datho7561 · Pull Request #1377 · eclipse-jdtls/eclipse-jdt-core-incubator

datho7561 · 2025-04-07T21:21:28Z

It wasn't counting qualified types in case statements as qualified, for instance.

Signed-off-by: Rob Stryker <stryker@redhat.com>

Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>

This is new Java 23 syntax. This PR should make 6 new tests pass (mostly from the java 23 completion suite) This PR also incorporates eclipse-jdt#3479, I forget specifically why, but it's needed. - Fixes to the javac AST converter - I did a hack in the converter to recover the following case, since javac doesn't handle it currently: ```java import module public class HelloWorld { } ``` - Adjust module completion relevance based on if it's required by the current module Signed-off-by: David Thompson <davthomp@redhat.com>

Complete type and method parameters after `@param` in Javadoc preceeding type and method declarations Signed-off-by: David Thompson <davthomp@redhat.com>

when underlying VarSymbol is error

For Blocks and Lambdas

* unused variables * unqualified access * switch from internal classes to api

This causes 6 regerssions because 'possible this escape' is now reported. Signed-off-by: David Thompson <davthomp@redhat.com>

- fix a bug related to ordering of tag names - get `@param| ` completion to work as expected - use `DOMCompletionUtil.findParent` instead of only checking the direct parent when calculating the node to use as context for completion (in the case of nodes within `Javadoc`) - split out `MemberRef` and `MethodRef` to their own completion cases - for now these are stubs - move the logic for type completion for `@see` and `@link` under the TagElement section, as it should be handled differently than the "default completion": - improve handling of qualified references - for the time being, suggest nothing when completing a type from a specific module. i.e. `@see java.base/java.util.|` no longer gives any results. Signed-off-by: David Thompson <davthomp@redhat.com>

Also needed but missed.

@see

Note that there are two code paths: one through `MemberRef` and another through an `@link` or `@see` `TagElement`. This is because the AST conversion tests expect the following to be a `TextElement` instead of a `MemberRef`: ```java /** * @see MyClass# */ ``` (and also:) ```java /** * @see # */ ``` However, the completion tests expect completion for MyClass' members to work in this case. Fixes eclipse-jdt#1103 Signed-off-by: David Thompson <davthomp@redhat.com>

* Type parameters * Annotations * Relevance

* Support type restriction for SwitchCase * Support for QualifiedType * Fix CompletionContext.getExpectedTypesSignatures()

datho7561 · 2025-04-07T21:30:23Z

it regressed; I'll need to figure out why:

PASS:    org.eclipse.jdt.core.tests.model.CompletionTests.testCatchClauseExceptionRef13
FAILURE: org.eclipse.jdt.core.tests.dom.ASTConverterTestAST8_2.test0602
        "\040\040\040\040\040\040\040\040\040\040\040\040\040\040\040\040\040\040" should have a binding
FAILURE: org.eclipse.jdt.core.tests.model.CompletionTests3.testBug575397b

        ----------- Expected ------------
        Thread.State[TYPE_REF]{State, , LThread$State;, null, null, 49}
        ------------ but was ------------
        Thread.State[TYPE_REF]{State, , LThread$State;, null, null, 51}
        ---------------------- ----------
         expected:<...State;, null, null, [49]}> but was:<...State;, null, null, [51]}>
FAILURE: org.eclipse.jdt.core.tests.model.CompletionTests.testBug343476a

        ----------- Expected ------------
        ZZZString[FIELD_REF]{ZZZString, Ltest.CompletionAfterCase2;, Ljava.lang.String;, ZZZString, null, 84}
        ------------ but was ------------
        ZZZString[FIELD_REF]{ZZZString, Ltest.CompletionAfterCase2;, Ljava.lang.String;, ZZZString, null, 86}
        ---------------------- ----------
         expected:<..., ZZZString, null, 8[4]}> but was:<..., ZZZString, null, 8[6]}>

Total failures: 3085
Total passes: 7213
New failures: 3
New passes: 1

datho7561 · 2025-04-08T18:18:29Z

Fixes 1, breaks 1

It wasn't counting qualified types in case statements as qualified, for instance. Signed-off-by: David Thompson <davthomp@redhat.com>

Rob Stryker and others added 30 commits April 2, 2025 09:39

Fix CompletionContextTests.test0116 and 1 other

2b010df

Signed-off-by: Rob Stryker <stryker@redhat.com>

Add javax.tools to o.e.j.c.tests.javac

c3d14a5

Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>

Fix ASTConverter15JLS4Test.test0008

31aef6b

Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>

Integrate javac library with a standalone bundle

8fd0316

@param | completion

aad2aa3

Complete type and method parameters after `@param` in Javadoc preceeding type and method declarations Signed-off-by: David Thompson <davthomp@redhat.com>

Add support for packages in completion

00e2b02

Do not create invalid JavacVariableBinding

b0d67d4

when underlying VarSymbol is error

Fix modifiers for types when coming from AST

20c13cb

Filter proposed packages

e573a75

Add completion of package keyword

0f575a1

Prevent NPE

2e37796

Fix some JavacTypeBinding.getKey with generic extends

be4875c

Resolve type for name when possible

15c7820

Improve JavacMethodBinding.isRaw

410e10e

Fix to ExpectedTypes

9fac806

For Blocks and Lambdas

Fix various warnings

331460d

* unused variables * unqualified access * switch from internal classes to api

Fix various possible NPEs

39e6569

Update README with updated args

42c9c5a

Remove unused methods from JavacBindingResolver

ebfebd1

Error IDs for problems unique to javac

64ceddd

This causes 6 regerssions because 'possible this escape' is now reported. Signed-off-by: David Thompson <davthomp@redhat.com>

Add NON_STATIC to relevance

dd22cfd

Do not insert classname for static methods inside expression

631a0ab

Add java.base/sun.nio.ch=ALL-UNNAMED to arguments

d8b3e5d

Also needed but missed.

Some work on type completion

e57f59e

* Type parameters * Annotations * Relevance

Improvements to completion

d69f89b

* Support type restriction for SwitchCase * Support for QualifiedType * Fix CompletionContext.getExpectedTypesSignatures()

Improve relevance computation for annotation without @target

540460f

Improve some import static type completion

23fac83

datho7561 force-pushed the fix-some-qualified-type-relevances branch from 7f19ad0 to 4dafcdf Compare April 8, 2025 18:18

Fix some qualified type relevances

0ae2a07

It wasn't counting qualified types in case statements as qualified, for instance. Signed-off-by: David Thompson <davthomp@redhat.com>

datho7561 force-pushed the fix-some-qualified-type-relevances branch from 4dafcdf to 0ae2a07 Compare April 8, 2025 18:22

datho7561 force-pushed the dom-with-javac branch from 0e01e4a to 29975c1 Compare May 29, 2025 17:36

rgrunber force-pushed the dom-with-javac branch from e059ea4 to 84a18c1 Compare June 25, 2025 15:09

mickaelistria force-pushed the dom-with-javac branch from 73d28b4 to aa8f401 Compare July 10, 2025 08:06

mickaelistria force-pushed the dom-with-javac branch from 4082278 to ebc593c Compare July 23, 2025 19:08

mickaelistria force-pushed the dom-with-javac branch from 11c94f4 to 99440ba Compare July 31, 2025 10:32

mickaelistria force-pushed the dom-with-javac branch from 6dc0d95 to 25a5a08 Compare August 26, 2025 09:00

robstryker force-pushed the dom-with-javac branch 3 times, most recently from b1b4e0e to 309f390 Compare September 8, 2025 20:48

mickaelistria force-pushed the dom-with-javac branch from 685330d to 959d707 Compare September 11, 2025 21:53

robstryker force-pushed the dom-with-javac branch from 2dbfcc7 to 6e1fd32 Compare September 17, 2025 18:31

mickaelistria force-pushed the dom-with-javac branch from 0b01689 to 87ead9e Compare October 8, 2025 23:36

mickaelistria force-pushed the dom-with-javac branch from 6d23874 to c8f8d92 Compare October 20, 2025 09:15

robstryker force-pushed the dom-with-javac branch from 055e846 to 18452eb Compare October 24, 2025 16:38

mickaelistria force-pushed the dom-with-javac branch from 411dfec to ac3eb19 Compare November 26, 2025 13:01

robstryker force-pushed the dom-with-javac branch 2 times, most recently from 5738537 to 9962d57 Compare December 2, 2025 20:28

robstryker force-pushed the dom-with-javac branch from 284e150 to 4bae1aa Compare January 19, 2026 16:15

robstryker force-pushed the dom-with-javac branch from 4bae1aa to c00ff74 Compare January 29, 2026 16:59

robstryker force-pushed the dom-with-javac branch 2 times, most recently from dd7aa18 to fbe5e1a Compare March 6, 2026 18:59

robstryker force-pushed the dom-with-javac branch 2 times, most recently from 2fcc4f8 to b7970ce Compare April 23, 2026 17:03

robstryker force-pushed the dom-with-javac branch 2 times, most recently from 86c88a2 to 4ccbd95 Compare May 7, 2026 17:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix some qualified type relevances#1377

Fix some qualified type relevances#1377
datho7561 wants to merge 1065 commits into
eclipse-jdtls:dom-with-javacfrom
datho7561:fix-some-qualified-type-relevances

datho7561 commented Apr 7, 2025

Uh oh!

datho7561 commented Apr 7, 2025

Uh oh!

datho7561 commented Apr 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

datho7561 commented Apr 7, 2025

Uh oh!

datho7561 commented Apr 7, 2025

Uh oh!

datho7561 commented Apr 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants