Fix two errors related to Code select and local variables#1457
Open
robstryker wants to merge 1344 commits into
Open
Fix two errors related to Code select and local variables#1457robstryker wants to merge 1344 commits into
robstryker wants to merge 1344 commits into
Conversation
robstryker
force-pushed
the
codeSelectRelatedToLocalVar
branch
2 times, most recently
from
3d3f9c2 to
ae783f0
Compare
Author
|
This PR needs rework because it depends on the a Javac Class using the same implementation to create the Local Variable that jdt.core in another spot, and they don't perfectly align. This PR attempts to unify the logic but I forgot we no longer build our own jdt.core. I'll finish this one tomorrow. |
robstryker
force-pushed
the
codeSelectRelatedToLocalVar
branch
2 times, most recently
from
4f4fa88 to
94e15e0
Compare
Author
|
This PR won't pass until eclipse-jdt#4054 is merged upstream. |
mickaelistria
force-pushed
the
dom-with-javac
branch
from
73d28b4 to
aa8f401
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
from
4082278 to
ebc593c
Compare
…ents02 Signed-off-by: Rob Stryker <stryker@redhat.com>
…ts06 Signed-off-by: Rob Stryker <stryker@redhat.com>
… other Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
…guments05 and one other Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
…patterns Signed-off-by: Rob Stryker <stryker@redhat.com>
…ly wrong Fixes 15 Signed-off-by: Rob Stryker <stryker@redhat.com>
…are parseable Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
also add default values.
Signed-off-by: Rob Stryker <stryker@redhat.com>
…lent tests Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <rob@oxbeef.net> Cleanup Signed-off-by: Rob Stryker <rob@oxbeef.net>
… when not seeking exact-match Signed-off-by: Rob Stryker <rob@oxbeef.net>
Signed-off-by: Rob Stryker <rob@oxbeef.net>
Signed-off-by: Rob Stryker <rob@oxbeef.net>
Signed-off-by: Rob Stryker <stryker@redhat.com>
robstryker
force-pushed
the
codeSelectRelatedToLocalVar
branch
from
94e15e0 to
e1b6bb5
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
from
6dc0d95 to
25a5a08
Compare
robstryker
force-pushed
the
dom-with-javac
branch
3 times, most recently
from
b1b4e0e to
309f390
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
from
685330d to
959d707
Compare
robstryker
force-pushed
the
dom-with-javac
branch
from
2dbfcc7 to
6e1fd32
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
from
0b01689 to
87ead9e
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
from
6d23874 to
c8f8d92
Compare
robstryker
force-pushed
the
dom-with-javac
branch
from
055e846 to
18452eb
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
from
411dfec to
ac3eb19
Compare
robstryker
force-pushed
the
dom-with-javac
branch
2 times, most recently
from
5738537 to
9962d57
Compare
robstryker
force-pushed
the
dom-with-javac
branch
from
284e150 to
4bae1aa
Compare
robstryker
force-pushed
the
dom-with-javac
branch
from
4bae1aa to
c00ff74
Compare
robstryker
force-pushed
the
dom-with-javac
branch
2 times, most recently
from
dd7aa18 to
fbe5e1a
Compare
robstryker
force-pushed
the
dom-with-javac
branch
2 times, most recently
from
2fcc4f8 to
b7970ce
Compare
robstryker
force-pushed
the
dom-with-javac
branch
2 times, most recently
from
86c88a2 to
4ccbd95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.