[WIP] Rework slightly how we current ignore match type#1459

Draft

mickaelistria wants to merge 1137 commits into

eclipse-jdtls:dom-with-javacfrom

mickaelistria:ignore-match-type

This pull request is big! We're only showing the most recent 250 commits

Commits on Apr 2, 2025

Avoid NPE in JavacBindingResolver (cont'd)
mickaelistria
committed
Do not suggest "extends" on enum or record
mickaelistria
committed
[Dogfooding] Fix issue where Record params are marked as unused

Rob Stryker
authored and
mickaelistria
committed
Move fix to UnusedTreeScanner

Rob Stryker
authored and
mickaelistria
committed
[Dogfooding] Fix unrecognized call to constructor to mark as used

Rob Stryker
authored and
mickaelistria
committed
Fix completing `out` from `System.|`

datho7561
authored and
mickaelistria
committed
Member types completion

datho7561
authored and
mickaelistria
committed
getDeclaredTypes() on a type binding loses the parameterized info for children

Rob Stryker
authored and
mickaelistria
committed
Fixes #1186 (possibly) - exceptions have wrong name in method mouseover

Rob Stryker
authored and
mickaelistria
committed
Fix possible ClassCastException trying to complete typeparam
mickaelistria
committed
Filter types based on access level

datho7561
authored and
mickaelistria
committed
Move `ExpectedTypes` into javac bundle

datho7561
authored and
mickaelistria
committed
In type completion, filter by unique FQN

datho7561
authored and
mickaelistria
committed
Avoid NPE in JavacBindingResolver
mickaelistria
committed
Complete super constructor invocation

datho7561
authored and
mickaelistria
committed
Fix some bugs in completion type filtering

datho7561
authored and
mickaelistria
committed
Fix `TryStatement` always marked as malformed by `JavacConverter`

datho7561
authored and
mickaelistria
committed
Fixes to array dimensions in `JavacConverter`

datho7561
authored and
mickaelistria
committed
Fix source range for array types when the `[` is unicode escape

datho7561
authored and
mickaelistria
committed
Add support for `MyClass.|this` completion

datho7561
authored and
mickaelistria
committed
Stop dealing with JLS2

akurtakov
authored and
mickaelistria
committed
Improve logic for 'inheritance' part of completion relevance

datho7561
authored and
mickaelistria
committed
Improve some support for completing missing type
mickaelistria
committed
Fix base conflict resolution
mickaelistria
committed
Enable debug output for failing mvn command
mickaelistria
committed
Improve completion for missing type
mickaelistria
committed
Remove pre JLS 8 convertions

akurtakov
authored and
mickaelistria
committed
Move key -> signature methods to `DOMCompletionUtil`

datho7561
authored and
mickaelistria
committed
Stabilize testDuplicateLocal

datho7561
authored and
mickaelistria
committed
Fix more CompletionWithMissingTypeTests
mickaelistria
committed
Make MatchLocator capable of working with DOM
mickaelistria
committed
Improve extends/implements completion

datho7561
authored and
mickaelistria
committed
Adapt to new API for JavacCompilerFactory
mickaelistria
committed
Adapt conversion to new TypePattern setter
mickaelistria
committed
Empower JavacBindingResolver.resolveWellKnownType
mickaelistria
committed
Do not check that some types are not returned by resolveWellKnownType
mickaelistria
committed
Return binding for missing type too
mickaelistria
committed
Fix some test cases for `this` completion

datho7561
authored and
mickaelistria
committed
Match locator was not initialized

Rob Stryker
authored and
mickaelistria
committed
JavaSearchTests.testCoreException - CoreException should be propagated, not caught

Rob Stryker
authored and
mickaelistria
committed
Pattern Wrappers must be cached to be reused

Rob Stryker
authored and
mickaelistria
committed
Change `@since` tag so that api tools doesn't complain

datho7561
authored and
mickaelistria
committed
some more proceedOnError
mickaelistria
committed
Support for --limit-modules
mickaelistria
committed
Issues with lombok

snjeza
authored and
mickaelistria
committed
Casted receiver completion

datho7561
authored and
mickaelistria
committed
Qualify field accesses with `ClassName.this` when they are shadowed

datho7561
authored and
mickaelistria
committed
Binding don't return irrelevant PackageBinding
mickaelistria
committed
Improve completion filtering for deprecation
mickaelistria
committed
Fix for .class completion with unknown type
mickaelistria
committed
Completion for field modifiers

datho7561
authored and
mickaelistria
committed
Allow using any static fields when initializing field

datho7561
authored and
mickaelistria
committed
Set token range for completions built out of IType s

datho7561
authored and
mickaelistria
committed
Get JavacTypeBinding.getDeclaredMethod ordered
mickaelistria
committed
Don't filter deprecated nodes inside same unit
mickaelistria
committed
Better resolve some variable
mickaelistria
committed
Run search tests using javac

datho7561
authored and
mickaelistria
committed
Detect expected types in lambda + treat boxed as native
mickaelistria
committed
Fix relevance for primitive/boxed type
mickaelistria
committed
Do not pass generated parameter names to method proposal
mickaelistria
committed
Fix completion for myMethod(|
mickaelistria
committed
Fix some packages in CompletionTests18
mickaelistria
committed
Suggested name completion

datho7561
authored and
mickaelistria
committed
Fix relevance for method reference
mickaelistria
committed
Replace wildcard in proposal signatures
mickaelistria
committed
Fix some cases of methodreference
mickaelistria
committed
Explicitly avoid lint when no problems are to be reported
mickaelistria
committed
Fix fine grain search with instanceof

datho7561
authored and
mickaelistria
committed
Temporarily disable issue to get build complete
mickaelistria
committed
Cache some JavaElement for bindings
mickaelistria
committed
Ignore model when typeBinding.getDeclaredMethods() is from source
mickaelistria
committed
Complete names of undeclared but assigned variables

datho7561
authored and
mickaelistria
committed
Cache key and simplify JavacMethodBinding.getJavaElement()
mickaelistria
committed
Qualified completion in case statements

datho7561
authored and
mickaelistria
committed
Filter out already included union types

datho7561
authored and
mickaelistria
committed
[DOM Search] Fix 100+ tests

Rob Stryker
authored and
mickaelistria
committed
[DOM Search] minor refactor

Rob Stryker
authored and
mickaelistria
committed
[DOM Search] - Fixes 14 search tests

Rob Stryker
authored and
mickaelistria
committed
[DOM Search] - Fix 6 tests related to generics

Rob Stryker
authored and
mickaelistria
committed
[DOM Search] Solve 10 issues related to match rule

Rob Stryker
authored and
mickaelistria
committed
[DOM Search] Fix JavaSearchGenericTypeEquivalentTests.testTypeSingleArgument01 and others

Rob Stryker
authored and
mickaelistria
committed
[DOM Search] Fix 12 more issues

Rob Stryker
authored and
mickaelistria
committed
[DOM Search] Fix 10 issues in resolving match levels

Rob Stryker
authored and
mickaelistria
committed
NPE revealed when a test fails

Rob Stryker
authored and
mickaelistria
committed
Handle regressions in binding key generation

Rob Stryker
authored and
mickaelistria
committed
[DOM] Fix testBug497719_0002, allowing super field and field access in try-with-resources

Rob Stryker
authored and
mickaelistria
committed
[DOM] implement illegal argument exception in binding.createArrayType(num)

Rob Stryker
authored and
mickaelistria
committed
Update versions in parent POM references for javac bundle

datho7561
authored and
mickaelistria
committed
Hopefully fix the model test failure

datho7561
authored and
mickaelistria
committed
Fix IType key sometimes doesn't end with `;` when it should

datho7561
authored and
mickaelistria
committed
Fix method comparion (signature instead of name)
mickaelistria
committed
Prevent CompletionFailure from bubbling up (and freezing IDE)
mickaelistria
committed
Expected type for SingleVariableDeclaration in CatchClause

datho7561
authored and
mickaelistria
committed
Suggest keywords before the top level type

datho7561
authored and
mickaelistria
committed
Completion for `case` keyword

datho7561
authored and
mickaelistria
committed
Completion for break and yield in switch statements and expr

datho7561
authored and
mickaelistria
committed
Keyword completion: differentiate between expressions and statements

datho7561
authored and
mickaelistria
committed
Many keyword completion fixes

datho7561
authored and
mickaelistria
committed
[DOM Search] - Fixes testParameterizedTypeSingleArgument01 and 6 others

Rob Stryker
authored and
mickaelistria
committed
[DOM Search] Fix testDeclarationOfReferencedTypes05 and 1 others

Rob Stryker
authored and
mickaelistria
committed
Fix CompletionContextTests0123 inside JavacConverter

Rob Stryker
authored and
mickaelistria
committed
Mark malformed

Rob Stryker
authored and
mickaelistria
committed
Keyword completion fixes for try/catch/finally and do-while

datho7561
authored and
mickaelistria
committed
Another round of keyword completions

datho7561
authored and
mickaelistria
committed
[DOM Search] implement matching on wildcards, extends, super, and other bugs

Rob Stryker
authored and
mickaelistria
committed
Undo some changes in jdt.core that are no longer relevant

Rob Stryker
authored and
mickaelistria
committed
Cache type hierarchy in `DOMCompletionUtil.findInSupers`

datho7561
authored and
mickaelistria
committed
Improve "override method" completion

datho7561
authored and
mickaelistria
committed
Hack to prevent OperationCanceledException from being propagated to logs

datho7561
authored and
mickaelistria
committed
Small fix to CompletionEngines and ExplectedTypes
mickaelistria
committed
Primitive types can autobox to `java.lang.Object`

datho7561
authored and
mickaelistria
committed
Prevent NPEs in completion tests

datho7561
authored and
mickaelistria
committed
Lazily resolve DOMCompletionContext.getEnclosingElement()
mickaelistria
committed
Fixes testParameterizedType_Bug83713 - Fix bad binding key

Rob Stryker
authored and
mickaelistria
committed
More error/NPE fixes in completion

datho7561
authored and
mickaelistria
committed
Avoid calling getKey() too greedily
mickaelistria
committed
Add "since" 4.32 tag for Java 24 constants.

rgrunber
authored and
mickaelistria
committed
Adjust based on javac library updates.

authored and
mickaelistria
committed
Set Java 24 requirement for org.eclipse.jdt.core.javac
mickaelistria
committed
Revert some changes in jdt.core to match upstream

datho7561
authored and
mickaelistria
committed
Fix some JAVADOC_LINE offsets
mickaelistria
committed
Clean up / revert some unnecessary changes in jdt.core

Rob Stryker
authored and
mickaelistria
committed
Use recovered type for erasure in javac bindings

datho7561
authored and
mickaelistria
committed
Filter visibility on search match (do not open type to get modifiers)
mickaelistria
committed
Avoid NPE when trying to resolve type from key
mickaelistria
committed
Some updates for Javadoc markdown conversion to Java 24
mickaelistria
committed
Prevent NPE
mickaelistria
committed
Map more problems
mickaelistria
committed
Key for anonymous type declarations

datho7561
authored and
mickaelistria
committed
Use SignatureUtils everywhere in DOMCompletionEngine
mickaelistria
committed
Fix insertion for enum constants
mickaelistria
committed
Fix relevance
mickaelistria
committed
[WIP] Handle `IAccessRules` in completion

datho7561
authored and
mickaelistria
committed
Improvements for ExpectedTypes
mickaelistria
committed
Fix testLocalVariableDeclaration1 and 10+ others

Rob Stryker
authored and
mickaelistria
committed
Lazily resolve whether variable is unique
mickaelistria
committed
Don't rely on getKey to ensure bindings are unique
mickaelistria
committed
Improve variableName proposals for collections
mickaelistria
committed
Stabilize some tests where ordering is important
mickaelistria
committed
Fix location for MemberRef without qualifier
mickaelistria
committed
Better separate source and bin in sourcepath/classpath
mickaelistria
committed
Complete on method name without expression
mickaelistria
committed
Do not fail on resolveBinding() when symbol has no matching .class
mickaelistria
committed
Always propose Object's methods
mickaelistria
committed
Improve perf for some completion based on index
mickaelistria
committed
Share Names
mickaelistria
committed
[DOM Search] Fix testStringParameterizedMultipleArguments01 and 02, 03, 04 and others

Rob Stryker
authored and
mickaelistria
committed
Fix testStringNestedMultipleArguments02

Rob Stryker
authored and
mickaelistria
committed
[DOM Search] check current package for non-imported missing types

Rob Stryker
authored and
mickaelistria
committed
[DOM Search] Parameterized types are not having source range replaced when unnecessarily qualified

Rob Stryker
authored and
mickaelistria
committed
[DOM Search] Various issues trying to match unresolved patterns

Rob Stryker
authored and
mickaelistria
committed
Incorrect hover and content assist with lombok

snjeza
authored and
mickaelistria
committed
Don't use not-upstream DOMCodeSelector.isGenerated()
mickaelistria
committed
Completion Perf: Delay `scrapeAccessibleBindings`
mickaelistria
committed
Ensure bindings are resolved before requesting import binding
mickaelistria
committed
Mark array types referenced in method @see reference as used
datho7561
committed
Map another two error messages
datho7561
committed

Commits on Apr 3, 2025

Commits on Apr 4, 2025

Commits on Apr 7, 2025

Fix testStringNestedMultipleArguments05

Rob Stryker
authored and
robstryker
committed
Fix testStringNestedSingleArgument01

Rob Stryker
authored and
robstryker
committed
Fix one issue - unsure which

Rob Stryker
authored and
robstryker
committed
Do not report imports for exact tests

Rob Stryker
authored and
robstryker
committed
Fix testParameterizedArrayTypeMultipleArguments01 and 6 others

Rob Stryker
authored and
robstryker
committed
Fix several regressions in JavaSearchGenericTypeEquivalentTests

Rob Stryker
authored and
robstryker
committed
Reorg how validating type parameters works

Rob Stryker
authored and
robstryker
committed
[DOM Search Tests] - Fixes 8 tests, add some support for exact search on type arguments

Rob Stryker
authored and
robstryker
committed
[DOM Search] Fix 8 tests related to search queries with no type params when node qualifier has type params

Rob Stryker
authored and
robstryker
committed
Fix testStringParameterizedMultipleArguments01

Rob Stryker
authored and
robstryker
committed
Fix testStringParameterizedMultipleArguments02

Rob Stryker
authored and
robstryker
committed
Set -Xproc:none when APT is disabled
mickaelistria
committed
Maybe fix semantic highlighting
datho7561
committed
[DOM Search] Fixes 4

Rob Stryker
authored and
mickaelistria
committed
Fix ASTConverterAST8Test.test0049()/test0052()

snjeza
authored and
datho7561
committed
Fix some qualification relevances
datho7561
committed

Commits on Apr 8, 2025

[DOM Search] Fixes several in JavaSearchGenericFieldTests

Rob Stryker
authored and
robstryker
committed

Commits on Apr 9, 2025

Convert `@serial` javadoc tag

datho7561
authored and
mickaelistria
committed

Commits on Apr 10, 2025

Completing enum sometimes double inserts the enum type name
datho7561
committed

Commits on Apr 11, 2025

Fix JavaSearchBugsTests.testBug83804_Type and 3 others

snjeza
authored and
datho7561
committed

Commits on Apr 14, 2025

Resolve method name to method
mickaelistria
committed
Reformat all files in javac bundle to get rid of trailing spaces and other automatic changes

Rob Stryker
authored and
robstryker
committed

Commits on Apr 15, 2025

Fixes #1370 - moving static method via refactor fails, DOMSearch

Rob Stryker
authored and
datho7561
committed
Prevent error when accepting keyword completion before loop
datho7561
committed

Commits on Apr 16, 2025

Don't try to read symbol for JavacErrorMethodBinding.isVarargs
mickaelistria
committed

Commits on Apr 18, 2025

Fixes testMethodDeclarationsElementPatternMultipleParamArguments02

Rob Stryker
authored and
robstryker
committed
Fix regressions

Rob Stryker
authored and
robstryker
committed
Fixes testMethodReferencesStringPatternSingleParamArguments09 and others

Rob Stryker
authored and
robstryker
committed

Commits on Apr 22, 2025

Fix ASTConverterTestAST8_2.test0602

snjeza
authored and
datho7561
committed

Commits on Apr 23, 2025

Don't suggest keywords in an array initializer
datho7561
committed

Commits on Apr 29, 2025

Commits on May 5, 2025

Commits on May 6, 2025

Commits on May 7, 2025

Make ASTConverterMarkdownText more tolerant
mickaelistria
committed

Commits on May 9, 2025

Fix completion for `blah.| unrelatedMethod()`
mickaelistria
committed

Commits on May 12, 2025

Commits on May 13, 2025

Do not filter out types from file when completing field type
datho7561
committed
[DOMSearch] - Fixes testMethodReferencesStringPatternSingleParamArguments02

Rob Stryker
authored and
robstryker
committed
[DOMSearch] Fixes testMethodReferencesStringPatternSingleParamArguments06

Rob Stryker
authored and
robstryker
committed
Fixes testMethodReferencesElementPatternSingleTypeParameter04 and one other

Rob Stryker
authored and
robstryker
committed
[JavacConverter] Imports are having static set twice, which breaks them

Rob Stryker
authored and
robstryker
committed
NPE Check

Rob Stryker
authored and
robstryker
committed
[DOMSearch] - Fix testMethodDeclarationsElementPatternMultipleParamArguments05 and one other

Rob Stryker
authored and
robstryker
committed
Cleanup

Rob Stryker
authored and
robstryker
committed
NPE

Rob Stryker
authored and
robstryker
committed
[DOM Search] More method searches

Rob Stryker
authored and
robstryker
committed
[DOM Search] Fixes 6 in JavaSearchGenericMethodExactTests

Rob Stryker
authored and
robstryker
committed
Fix / Swallow 20 IllegalArgumentExceptions when comparing unresolved patterns

Rob Stryker
authored and
robstryker
committed
[DOM Search] Bandaid Fix for problem with wildcard key being completely wrong

Rob Stryker
authored and
robstryker
committed
[DOM Search] Fix 12 - fixes isQuestionMark and ensures wildcard keys are parseable

Rob Stryker
authored and
robstryker
committed
Fix some regressions

Rob Stryker
authored and
robstryker
committed
NPE

Rob Stryker
authored and
robstryker
committed
Fix test0264 in ASTConverter15JLS4Test

Rob Stryker
authored and
robstryker
committed

Commits on May 14, 2025

Fix JavacAnnotationBinding.getAllMemberValuePairs()
mickaelistria
committed
Random Fixes in AST Converter tests

Rob Stryker
authored and
mickaelistria
committed
[DOM Search] Fixes testParameterizedTypeMultipleArguments01 in equivalent tests

Rob Stryker
authored and
robstryker
committed
[DOM Search] Fixes testParameterizedType_Bug83713

Rob Stryker
authored and
robstryker
committed
Cleanup an unnecessary hard-coded signature

Rob Stryker
authored and
robstryker
committed
Fixes testStringAnyStrings06 - name match with wildcard

Rob Stryker
authored and
robstryker
committed

Commits on May 16, 2025

Improve JavacMethodBinding.isRaw()
mickaelistria
committed
[Search] Fix qualifiedSourceName
mickaelistria
committed
Revert "[Search] Fix qualifiedSourceName"
mickaelistria
committed
Fix an NPE in testMethodReferencesElementPatternMultipleTypeParameter03

Rob Stryker
authored and
robstryker
committed

Commits on May 19, 2025

Commits on May 20, 2025

Commits on May 21, 2025

[Search] Support OrPattern for DOM
mickaelistria
committed
[Search] Do not visit AnnotationTypeDeclaration name
mickaelistria
committed
Fix an IllegalArgumentException when calling member.getType()

Rob Stryker
authored and
robstryker
committed
[Search] Honor `searchFor`
mickaelistria
committed

Commits on May 22, 2025

Commits on May 26, 2025

Fix various NPEs

Rob Stryker
authored and
mickaelistria
committed
Rework slightly how we current ignore match type
mickaelistria
committed