Skip to content

Commit d4482a5

Browse files
committed
Configure Guice classloading for Java 21+ compatibility
Add -Dguice_custom_class_loading=CHILD to avoid sun.misc.Unsafe warnings on Java 21+. This prevents "terminally deprecated method" warnings from Guice 5.1.0's HiddenClassDefiner. Changes: - Add flag to Eclipse launch configurations (3 files) - Add flag to product definitions (languageServer, syntaxServer) - Add flag to tycho-surefire test configuration Based on Maven fix: apache/maven#10992 Resolves sun.misc.Unsafe::staticFieldBase deprecation warnings
1 parent 1c49c3a commit d4482a5

7 files changed

Lines changed: 8 additions & 193 deletions

File tree

GUICE_UPGRADE_ANALYSIS.md

Lines changed: 0 additions & 189 deletions
This file was deleted.

launch/jdt.ls.remote.server.launch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
<stringAttribute key="org.eclipse.jdt.launching.JRE_CONTAINER" value="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-21"/>
3737
<stringAttribute key="org.eclipse.jdt.launching.PROGRAM_ARGUMENTS" value="-os ${target.os} -ws ${target.ws} -arch ${target.arch} -nl ${target.nl} -consoleLog"/>
3838
<stringAttribute key="org.eclipse.jdt.launching.SOURCE_PATH_PROVIDER" value="org.eclipse.pde.ui.workbenchClasspathProvider"/>
39-
<stringAttribute key="org.eclipse.jdt.launching.VM_ARGUMENTS" value="-Djava.import.generatesMetadataFilesAtProjectRoot=false"/>
39+
<stringAttribute key="org.eclipse.jdt.launching.VM_ARGUMENTS" value="-Dguice_custom_class_loading=CHILD -Djava.import.generatesMetadataFilesAtProjectRoot=false"/>
4040
<stringAttribute key="pde.version" value="3.3"/>
4141
<stringAttribute key="product" value="org.eclipse.sdk.ide"/>
4242
<setAttribute key="selected_features"/>

launch/jdt.ls.socket-stream.launch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
<stringAttribute key="org.eclipse.jdt.launching.JRE_CONTAINER" value="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-21"/>
3838
<stringAttribute key="org.eclipse.jdt.launching.PROGRAM_ARGUMENTS" value="-os ${target.os} -ws ${target.ws} -arch ${target.arch} -nl ${target.nl} -consoleLog"/>
3939
<stringAttribute key="org.eclipse.jdt.launching.SOURCE_PATH_PROVIDER" value="org.eclipse.pde.ui.workbenchClasspathProvider"/>
40-
<stringAttribute key="org.eclipse.jdt.launching.VM_ARGUMENTS" value="-Djava.import.generatesMetadataFilesAtProjectRoot=false"/>
40+
<stringAttribute key="org.eclipse.jdt.launching.VM_ARGUMENTS" value="-Dguice_custom_class_loading=CHILD -Djava.import.generatesMetadataFilesAtProjectRoot=false"/>
4141
<stringAttribute key="pde.version" value="3.3"/>
4242
<stringAttribute key="product" value="org.eclipse.sdk.ide"/>
4343
<setAttribute key="selected_features"/>

launch/jdt.ls.socket-stream.syntaxserver.launch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
<stringAttribute key="org.eclipse.jdt.launching.JRE_CONTAINER" value="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-21"/>
4040
<stringAttribute key="org.eclipse.jdt.launching.PROGRAM_ARGUMENTS" value="-os ${target.os} -ws ${target.ws} -arch ${target.arch} -nl ${target.nl} -consoleLog"/>
4141
<stringAttribute key="org.eclipse.jdt.launching.SOURCE_PATH_PROVIDER" value="org.eclipse.pde.ui.workbenchClasspathProvider"/>
42-
<stringAttribute key="org.eclipse.jdt.launching.VM_ARGUMENTS" value="-Djava.import.generatesMetadataFilesAtProjectRoot=false"/>
42+
<stringAttribute key="org.eclipse.jdt.launching.VM_ARGUMENTS" value="-Dguice_custom_class_loading=CHILD -Djava.import.generatesMetadataFilesAtProjectRoot=false"/>
4343
<stringAttribute key="pde.version" value="3.3"/>
4444
<stringAttribute key="product" value="org.eclipse.sdk.ide"/>
4545
<setAttribute key="selected_features"/>

org.eclipse.jdt.ls.product/languageServer.product

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
</configIni>
88

99
<launcherArgs>
10+
<vmArgs>-Dguice_custom_class_loading=CHILD
11+
</vmArgs>
1012
<vmArgsMac>-XstartOnFirstThread -Dorg.eclipse.swt.internal.carbon.smallFonts
1113
</vmArgsMac>
1214
</launcherArgs>

org.eclipse.jdt.ls.product/syntaxServer.product

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
</configIni>
88

99
<launcherArgs>
10+
<vmArgs>-Dguice_custom_class_loading=CHILD
11+
</vmArgs>
1012
<vmArgsMac>-XstartOnFirstThread -Dorg.eclipse.swt.internal.carbon.smallFonts
1113
</vmArgsMac>
1214
</launcherArgs>

org.eclipse.jdt.ls.tests/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
<artifactId>tycho-surefire-plugin</artifactId>
4949
<version>${tycho-version}</version>
5050
<configuration>
51-
<argLine>${tycho.testArgLine} ${os.testArgs} "${lombokArgs}"</argLine>
51+
<argLine>-Dguice_custom_class_loading=CHILD ${tycho.testArgLine} ${os.testArgs} "${lombokArgs}"</argLine>
5252
<runOrder>random</runOrder>
5353
<providerProperties>
5454
<excludegroups>org.eclipse.jdt.ls.tests.Unstable</excludegroups>

0 commit comments

Comments
 (0)