perf: completion micro-optimizations#3737
Open
fbricon wants to merge 3 commits intoeclipse-jdtls:mainfrom
Open
perf: completion micro-optimizations#3737fbricon wants to merge 3 commits intoeclipse-jdtls:mainfrom
fbricon wants to merge 3 commits intoeclipse-jdtls:mainfrom
Conversation
Contributor
fbricon
commented
Mar 12, 2026
fbricon
commented
- Optimize completion performance by caching preference manager calls
- Combine double loop in completion proposal ranking
- Optimize completion command assignment loop
Cache getPreferencesManager().getClientPreferences() results in local variables to avoid redundant method calls during completion requests. This eliminates duplicate lookups in hot code paths. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Merge two separate loops that iterate through proposals into a single loop, reducing iterations from 2N to N. Also pre-size the HashMap to avoid resizing during population. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Improve performance of the command assignment loop by: - Early exit when data map is null (fast path) - Use Map.get() instead of getOrDefault() for better performance - Reduce unnecessary string initializations - Better null checking reduces wasted iterations Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.