Add VarargsWarningsSubProcessor quick-fixes#3754
Merged
datho7561 merged 1 commit intoeclipse-jdtls:mainfrom Apr 15, 2026
Merged
Add VarargsWarningsSubProcessor quick-fixes#3754datho7561 merged 1 commit intoeclipse-jdtls:mainfrom
datho7561 merged 1 commit intoeclipse-jdtls:mainfrom
Conversation
Contributor
jjohnstn
commented
Apr 10, 2026
jjohnstn
commented
- add new VarargsWarningsSubProcessor class
- enable QuickFixProcessor quick-fixes using VarargsWarningsSubProcessor
- add new tests to ModifierCorrectionsQuickFixTest
- add new VarargsWarningsSubProcessor class - enable QuickFixProcessor quick-fixes using VarargsWarningsSubProcessor - add new tests to ModifierCorrectionsQuickFixTest
Contributor
Author
|
Hi @datho7561 These are quick-fixes that already have base processor support in jdt.core.manipulation but didn't have a sub-processor class in jdt.ls to use them. |
Contributor
|
test this please |
Contributor
|
one regression listed in the results, so I'm checking that |
datho7561
approved these changes
Apr 15, 2026
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Looks good from my testing. Just waiting on CI to make sure that the new failing test is flaky and not a real regression. Thanks Jeff!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.